Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E test verifies Kubeflow installed via Deployment Manager #836

Closed
jlewi opened this issue May 21, 2018 · 3 comments
Closed

E2E test verifies Kubeflow installed via Deployment Manager #836

jlewi opened this issue May 21, 2018 · 3 comments
Assignees
@kunmingg
Labels
platform/gcp priority/p1

Comments

@jlewi
Copy link
Contributor

jlewi commented May 21, 2018

Background:
#823 Start Deploying bootstrapper via deployment manager
#757 Install Kubeflow by the deployment manager

To verify this is working we need to update the E2E test to verify that Kubeflow is actually deployed correctly. I think this is currently blocked by #832

/assign @kunmingg
@jlewi jlewi mentioned this issue May 22, 2018
Closed
@jlewi
Copy link
Contributor Author

jlewi commented May 22, 2018

I think we should do the following

  • Create a variant of deploy_kubeflow.py which uses deployment manager

    • A python script will be easier to add things like retries and error testing and also wrap it in a test case

  • We should allow the YAML file provided to deployment manager( cluster-kubeflow.yaml) to be specified via ConfigMap. This will make it easy to override via the Argo spec so that we can test different packages.

jlewi added a commit to jlewi/kubeflow that referenced this issue May 24, 2018
@jlewi
Create a python script to deploy Kubeflow on GCP via deployment manager.
4c99f72 
* The script replaces our bash script.
* A python script should make it easier to make our tests more robust
  by adding retries and error handling.

Related to kubeflow#836 verify Kubeflow deployed correctly with deployment manager.
jlewi added a commit to jlewi/kubeflow that referenced this issue May 24, 2018
@jlewi
Create a python script to deploy Kubeflow on GCP via deployment manager.
907d6f6 
* The script replaces our bash script.
* A python script should make it easier to make our tests more robust
  by adding retries and error handling.

Related to kubeflow#836 verify Kubeflow deployed correctly with deployment manager.
@jlewi jlewi mentioned this issue May 24, 2018
Merged
jlewi added a commit to jlewi/kubeflow that referenced this issue May 24, 2018
@jlewi
Create python scripts for deploying Kubeflow on GCP via deployment ma…
3fa104e 
…nager.

* The scripts replaces our bash commands
* For teardown we want to add retries to better handle INTERNAL_ERRORS
  with deployment manager that are causing the test to be flaky.

Related to kubeflow#836 verify Kubeflow deployed correctly with deployment manager.
jlewi added a commit to jlewi/kubeflow that referenced this issue May 24, 2018
@jlewi
Create python scripts for deploying Kubeflow on GCP via deployment ma…
c5834bc 
…nager.

* The scripts replaces our bash commands
* For teardown we want to add retries to better handle INTERNAL_ERRORS
  with deployment manager that are causing the test to be flaky.

Related to kubeflow#836 verify Kubeflow deployed correctly with deployment manager.

* Fix resource_not_found errors in delete (kubeflow#833)

* The not found error was due to the type providers for K8s resources
  being deleted before the corresponding K8s resources. So the subsequent
  delete of the K8s resource would fail because the type provider did not
  exist.

* We fix this by using a $ref to refer to the type provider in the type field
  of K8s resources.
k8s-ci-robot pushed a commit that referenced this issue May 25, 2018
@jlewi @k8s-ci-robot
Create a python script to deploy Kubeflow on GCP via deployment manag…
0f0cb1c 
…er. (#866)

* Create python scripts for deploying Kubeflow on GCP via deployment manager.

* The scripts replaces our bash commands
* For teardown we want to add retries to better handle INTERNAL_ERRORS
  with deployment manager that are causing the test to be flaky.

Related to #836 verify Kubeflow deployed correctly with deployment manager.

* Fix resource_not_found errors in delete (#833)

* The not found error was due to the type providers for K8s resources
  being deleted before the corresponding K8s resources. So the subsequent
  delete of the K8s resource would fail because the type provider did not
  exist.

* We fix this by using a $ref to refer to the type provider in the type field
  of K8s resources.

* * deletePolicy can't be set per resource

* Autoformat jsonnet.
@ankushagarwal
Copy link
Contributor

@jlewi Can this be closed since #866 is merged?

@jlewi
Copy link
Contributor Author

jlewi commented Jun 5, 2018

#866 doesn't actually verify that the resulting Kubeflow deployment is functional.

Fixed by #894

@jlewi jlewi closed this as completed Jun 5, 2018
saffaalvi pushed a commit to StatCan/kubeflow that referenced this issue Feb 11, 2021
@jlewi @k8s-ci-robot
Create a python script to deploy Kubeflow on GCP via deployment manag…
0cf2719 
…er. (kubeflow#866)

* Create python scripts for deploying Kubeflow on GCP via deployment manager.

* The scripts replaces our bash commands
* For teardown we want to add retries to better handle INTERNAL_ERRORS
  with deployment manager that are causing the test to be flaky.

Related to kubeflow#836 verify Kubeflow deployed correctly with deployment manager.

* Fix resource_not_found errors in delete (kubeflow#833)

* The not found error was due to the type providers for K8s resources
  being deleted before the corresponding K8s resources. So the subsequent
  delete of the K8s resource would fail because the type provider did not
  exist.

* We fix this by using a $ref to refer to the type provider in the type field
  of K8s resources.

* * deletePolicy can't be set per resource

* Autoformat jsonnet.
yanniszark pushed a commit to arrikto/kubeflow that referenced this issue Feb 15, 2021
@hougangliu @k8s-ci-robot
Remove used katib-manager code (kubeflow#836)
d03a551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kunmingg kunmingg

Labels
platform/gcp priority/p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jlewi @ankushagarwal @kunmingg