Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Deployment Manager to bring up clusters for running E2E tests #894

Merged
merged 2 commits into from Jun 5, 2018
Merged

Use Deployment Manager to bring up clusters for running E2E tests #894

merged 2 commits into from Jun 5, 2018

Conversation

ankushagarwal
Copy link
Contributor

@ankushagarwal ankushagarwal commented May 30, 2018 •
edited

  • Use Deployment Manager to bring up clusters for running E2E tests
    • Running e2e tests in a separate cluster will provide better isolation
    • It will be easier to deploy multiple clusters for complex tests which involve multiple versions of CRDs
  • Delete gke_deploy workflow as it is no longer needed
  • Use deploy_kubeflow_gcp.py and teardown_kubeflow_gcp.py to manage the deployments
  • Update workflows.libsonnet with the new workflow

Related to #852

This change is Reviewable

@ankushagarwal
Copy link
Contributor Author

/retest

1 similar comment
@ankushagarwal
Copy link
Contributor Author

/retest

@ankushagarwal ankushagarwal changed the title WIP Don't Review Use Deployment Manager to bring up clusters for running E2E tests Jun 2, 2018
@ankushagarwal
Copy link
Contributor Author

/cc @jlewi
/cc @kunmingg

jlewi
jlewi reviewed Jun 4, 2018
View reviewed changes
testing/dm_configs/cluster-kubeflow.yaml Outdated
@@ -23,15 +23,24 @@ resources:
# Path for the bootstrapper image.
bootstrapperImage: gcr.io/kubeflow-images-public/bootstrapper:latest
bootstrapperConfig: |
registries:
# For e2e test target repo we skip registry repo and branch
# Instead we use PR code attached to container by volumn.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

volumn -> volume

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

jlewi
jlewi reviewed Jun 4, 2018
View reviewed changes
testing/dm_configs/cluster-kubeflow.yaml Outdated
@@ -23,15 +23,24 @@ resources:
# Path for the bootstrapper image.
bootstrapperImage: gcr.io/kubeflow-images-public/bootstrapper:latest
bootstrapperConfig: |
registries:
# For e2e test target repo we skip registry repo and branch
Copy link
Contributor

@jlewi jlewi Jun 4, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused, how is the bootstrapper getting the source code @ the version being tested in a pre/post submit?
Where is the volume containing the code created?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is incorrect. I have updated this. In the workflow we build the bootstrap image and we bake the source code from the PR into the bootstrap image. The source code is obtained from the checked out git repo in the shared NFS.

The build_image step is here. The build_image.sh script is here

@ankushagarwal
Copy link
Contributor Author

/retest

@jlewi
Copy link
Contributor

jlewi commented Jun 5, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d578256 into kubeflow:master Jun 5, 2018
@jlewi jlewi mentioned this pull request Jun 5, 2018
Closed
wmuizelaar pushed a commit to bolcom/kubeflow that referenced this pull request Jun 5, 2018
@wmuizelaar
Use Deployment Manager to bring up clusters for running E2E tests (ku…
6c364b2 
…beflow#894)

* Use Deployment Manager to bring up clusters for running E2E tests

* Update comment in cluster-kubeflow.yaml
@ankushagarwal ankushagarwal deleted the e2etest-v1alpha2 branch June 5, 2018 16:15
@jlewi jlewi mentioned this pull request Jun 5, 2018
Closed
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
@k8s-ci-robot
Use Deployment Manager to bring up clusters for running E2E tests (ku…
34591eb 
…beflow#894)

* Use Deployment Manager to bring up clusters for running E2E tests

* Update comment in cluster-kubeflow.yaml
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
@gaocegege @k8s-ci-robot
feat: Support running (kubeflow#894)
5d46799 
* feat: Support running

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* fix: Do not mark trial running when the job is created

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* fix: Add nil pointer check

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* fix: Avoid nil pointer

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* fix: Update

Signed-off-by: Ce Gao <gaoce@caicloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlewi jlewi jlewi left review comments

@kunmingg kunmingg Awaiting requested review from kunmingg

Assignees

@jlewi jlewi

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ankushagarwal @jlewi @k8s-ci-robot