Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression Jupyter notebooks no longer include python2 runtime #906

Closed
jlewi opened this issue Jun 1, 2018 · 4 comments
Closed

Regression Jupyter notebooks no longer include python2 runtime #906

jlewi opened this issue Jun 1, 2018 · 4 comments
Assignees
Labels
area/jupyter Issues related to Jupyter priority/p1

Comments

@jlewi
Copy link
Contributor

jlewi commented Jun 1, 2018

I just tried gcr.io/kubeflow-images-public/tensorflow-1.7.0-notebook-cpu:v20180601-2464851a

And I didn't see an option for a python2 runtime which is needed for TFX/Beam support.

My guess is this was a regression introduced when refactored the notebook image to support mounting all of /home/jovyan on a PVC.

/cc @pdmack

@jlewi jlewi added priority/p1 area/jupyter Issues related to Jupyter labels Jun 1, 2018
@pdmack
Copy link
Member

pdmack commented Jun 1, 2018

@jlewi sort of. Looks like we were dually supporting py3 and py2 by installing and activating py2 in the jovyan homedir, which of course gets wiped in prep for the PVC check. Does that track?
Which means I need to preserve that as well. 😁
/assign @pdmack

@jlewi
Copy link
Contributor Author

jlewi commented Jun 1, 2018

conda environments are kind of a mystery to me.

@ojarjur Might have more insight.

@ojarjur
Copy link
Contributor

ojarjur commented Jun 1, 2018

@jlewi The theory presented by @pdmack sounds right. If the user directory is being wiped out after installing the ipykernel, then it will not be available.

@pdmack
Copy link
Member

pdmack commented Jun 1, 2018

It appears we don't need to install to jovyan at all, but instead the new global env location /opt/conda. But I'm going to review the older images and see what (if any) differences there may be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jupyter Issues related to Jupyter priority/p1
Projects
None yet
Development

No branches or pull requests

3 participants