Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install py2 to global conda env #907

Merged
merged 1 commit into from Jun 5, 2018

Conversation

pdmack
Copy link
Member

@pdmack pdmack commented Jun 1, 2018

Fixes #906

PTAL
/cc @jlewi
/cc @ankushagarwal

Are we good with just dropping the --user py2 install and letting it get installed to /opt/conda/envs? Are there some other tests I should try?

Also, should we install the Beam pkg @jlewi was referring to in #906 while we're here?

screen shot 2018-06-01 at 11 47 20 am

screen shot 2018-06-01 at 1 01 54 pm


This change is Reviewable

@ankushagarwal
Copy link
Contributor

Installing beam SGTM

@ankushagarwal
Copy link
Contributor

My bad. tensorflow-model-analysis seems to install apache-beam already : https://github.com/tensorflow/model-analysis/blob/master/setup.py#L189

@pdmack pdmack changed the title Install py2 to global conda env [WIP] Install py2 to global conda env Jun 1, 2018
@pdmack
Copy link
Member Author

pdmack commented Jun 1, 2018

Yep, I misinterpreted @jlewi's comment. Doing some more testing.

@pdmack
Copy link
Member Author

pdmack commented Jun 4, 2018

@ankushagarwal Do you/we have a particular build environment for the NB images when TFMA is enabled? I consistently get a SIGILL from your post-refactor build in my env:

/bin/bash: line 1:   283 Illegal instruction     (core dumped) jupyter nbextension install --py --symlink tensorflow_model_analysis

This happens even in the NB container itself if I try to manually install it.

@pdmack
Copy link
Member Author

pdmack commented Jun 5, 2018

OK figured out that my build CPU env wasn't up to snuff. If there's no AVX support then that extension install fails because it tries to do a TF import. Will do more py2 testing on another env tomorrow.

@jlewi
Copy link
Contributor

jlewi commented Jun 5, 2018

Thank you!

@pdmack
Copy link
Member Author

pdmack commented Jun 5, 2018

I think this is OK now. @jlewi can you try this out and see if it's satisfactory?

docker pull pdmack/tf-notebook:1.7.0

@jlewi
Copy link
Contributor

jlewi commented Jun 5, 2018

Confirmed imports work in a Python 2 environment

import apache_beam
import tensorflow_model_analysis as tfma

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pdmack pdmack changed the title [WIP] Install py2 to global conda env Install py2 to global conda env Jun 5, 2018
@k8s-ci-robot k8s-ci-robot merged commit 1ec4b4f into kubeflow:master Jun 5, 2018
@pdmack pdmack deleted the 906-nb-py2-regression branch June 12, 2018 20:07
jlewi added a commit to jlewi/kubeflow that referenced this pull request Jun 18, 2018
* There's no reason to upgrade to a more recent Jupyter image because it
looks like the last change to the images was kubeflow#907 on 06/05.

Fix kubeflow#1014
k8s-ci-robot pushed a commit that referenced this pull request Jun 18, 2018
* There's no reason to upgrade to a more recent Jupyter image because it
looks like the last change to the images was #907 on 06/05.

Fix #1014
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
* There's no reason to upgrade to a more recent Jupyter image because it
looks like the last change to the images was kubeflow#907 on 06/05.

Fix kubeflow#1014
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
* fix: Add Suggestion into CI

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* fix: Use 3.6

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* fix: Fix Hyperband

Signed-off-by: Ce Gao <gaoce@caicloud.io>
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
* publish image replicate templates

* rename path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants