New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install py2 to global conda env #907
Conversation
Installing beam SGTM |
My bad. tensorflow-model-analysis seems to install apache-beam already : https://github.com/tensorflow/model-analysis/blob/master/setup.py#L189 |
Yep, I misinterpreted @jlewi's comment. Doing some more testing. |
@ankushagarwal Do you/we have a particular build environment for the NB images when TFMA is enabled? I consistently get a SIGILL from your post-refactor build in my env:
This happens even in the NB container itself if I try to manually install it. |
OK figured out that my build CPU env wasn't up to snuff. If there's no AVX support then that extension install fails because it tries to do a TF import. Will do more py2 testing on another env tomorrow. |
Thank you! |
I think this is OK now. @jlewi can you try this out and see if it's satisfactory?
|
Confirmed imports work in a Python 2 environment
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* There's no reason to upgrade to a more recent Jupyter image because it looks like the last change to the images was kubeflow#907 on 06/05. Fix kubeflow#1014
* There's no reason to upgrade to a more recent Jupyter image because it looks like the last change to the images was kubeflow#907 on 06/05. Fix kubeflow#1014
* fix: Add Suggestion into CI Signed-off-by: Ce Gao <gaoce@caicloud.io> * fix: Use 3.6 Signed-off-by: Ce Gao <gaoce@caicloud.io> * fix: Fix Hyperband Signed-off-by: Ce Gao <gaoce@caicloud.io>
* publish image replicate templates * rename path
Fixes #906
PTAL
/cc @jlewi
/cc @ankushagarwal
Are we good with just dropping the
--user
py2 install and letting it get installed to/opt/conda/envs
? Are there some other tests I should try?Also, should we install the Beam pkg @jlewi was referring to in #906 while we're here?
This change is