-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add katib to the centralUI #1179
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@swiftdiaries Just a reminder if reviewers aren't responding you should ping them or assign new reviewers. /unassign @jimexist /assign @kunmingg |
@@ -25,6 +25,7 @@ <h1>Kubeflow</h1> | |||
<a href="/hub/" class="mdl-layout__tab is-active mdl-color-text--white">JupyterHub</a> | |||
<a href="/tfjobs/ui/" class="mdl-layout__tab mdl-color-text--white">TFJob Dashboard</a> | |||
<a href="/k8s/ui/" class="mdl-layout__tab mdl-color-text--white">k8s Dashboard</a> | |||
<a href="/katib/" class="mdl-layout__tab mdl-color-text--white">katib</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test this? I think we want to redirect to katib/projects/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/katib/ automatically redirects to /katib/projects so I left it like that.
Closing in favor of #1242. |
* Add unittest for darts * Fix pip * Change chocolate className Change timeout for chocolate test
* Related to kubeflow#1174. * This is a follow on to kubeflow#1175. kubeflow#1175 attempted to fix this issue but the unittest was insufficient because it didn't handle the case where there were multiple K8s resources in a file. * The test is updated to handle that case. We use a more powerful YAML processing library kyaml from kustomize. * Also remove empty annotations (GoogleCloudPlatform/kubeflow-distribution#16) because this triggers a bug in kpt.
Addresses: kubeflow/katib#128.
For now this PR assumes that Katib is always deployed. Upcoming PR's will address this better.
This change is