Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split kubeflow-core into individual prototypes #1207

Merged
merged 1 commit into from Jul 17, 2018
Merged

Split kubeflow-core into individual prototypes #1207

merged 1 commit into from Jul 17, 2018

Conversation

ankushagarwal
Copy link
Contributor

@ankushagarwal ankushagarwal commented Jul 13, 2018 •
edited

Splits into

  • Ambassador
  • Jupyterhub
  • Central Dashboard
  • Spartakus
  • tf-job-operator

Also

  • Update bootstrapper where kubeflow-core is hardcoded
  • Other updates to READMEs

Changes to the website are here : kubeflow/website#91

Fixes #1107

This change is Reviewable

@ankushagarwal
Copy link
Contributor Author

/retest

@ankushagarwal ankushagarwal mentioned this pull request Jul 14, 2018
Merged
@ankushagarwal
Copy link
Contributor Author

/retest

1 similar comment
@ankushagarwal
Copy link
Contributor Author

/retest

Ambassador refactor
99bfa4a 
Jupyterhub refactor

Central Dashboard Refactor

TFJob Refactor

Spartakus

WIP

wip

update docs
@ankushagarwal
Copy link
Contributor Author

/cc @kunmingg @lluunn
/assign @jlewi

@ankushagarwal ankushagarwal changed the title WIP Split kubeflow-core into individual prototypes Split kubeflow-core into individual prototypes Jul 16, 2018
jlewi
jlewi suggested changes Jul 17, 2018
View reviewed changes
Copy link
Contributor

@jlewi jlewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 22 files reviewed, 2 unresolved discussions (waiting on @ankushagarwal, @willingc, @lluunn, @wbuchwalter, and @kunmingg)

kubeflow/core/prototypes/jupyterhub.jsonnet, line 6 at r1 (raw file):

// @shortDescription jupyterhub Component
// @param name string Name
// @optionalParam cloud string null Cloud

Can we just get rid of the Cloud parameter.

Created issue #1227

kubeflow/core/prototypes/tf-job-operator.jsonnet, line 7 at r1 (raw file):

// @param name string Name to give to each of the components
// @optionalParam namespace string null Namespace to use for the components. It is automatically inherited from the environment if not set.
// @optionalParam cloud string null String identifying the cloud to customize the deployment for.

Do we still use Cloud? Or can we get rid of it?

@ankushagarwal
Copy link
Contributor Author

We do use cloud parameter for some components

  • jupyterhub - cloud is used to set the images. alibaba uses its own registry instead of gcr
  • ambassador - cloud is used to determine the isDashboardTls parameter

@jlewi
Copy link
Contributor

jlewi commented Jul 17, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c674d2b into kubeflow:master Jul 17, 2018
@ankushagarwal ankushagarwal deleted the split-components branch July 18, 2018 22:15
k8s-ci-robot pushed a commit to kubeflow/website that referenced this pull request Aug 17, 2018
@k8s-ci-robot
Split kubeflow-core into individual prototypes (#91)
6cda4b6 
See kubeflow/kubeflow#1207

Update according to new sections
abhi-g added a commit to abhi-g/website that referenced this pull request Aug 27, 2018
@abhi-g
Add events links (kubeflow#162) (kubeflow#179)
25b678e 
* Add links

Update links to past events and add videos & slides
Add links to upcoming events

* Add origins video & interview with jlewi

* Fix title

* Update start time of video

Add doc on AVX2 and Haswell (kubeflow#131)

* Add doc on AVX2 and Haswell

* update

* comment

Create S3 documentation for tf-serving (kubeflow#135)

Slight refactor and inclustion of S3 to our tf-serving docs

Website versioning (kubeflow#136)

* Add richardsliu to OWNERS in kubeflow/website

* Test website versioning

* Revert "Test website versioning"

This reverts commit 67ea8da.

* Testing website versioning

* Add richardsliu to OWNERS in kubeflow/website

Test website versioning

Revert "Test website versioning"

This reverts commit 67ea8da.

Testing website versioning

* Fix css

* Fixing merge errors

* Fix css

* Fix css

* Fix css

* Fix css

* Change master label to latest

* Parameterize links in docs to point to the right version

* Fix shortcode

* Fix shortcode

* Fix shortcodes

* Fix more links

* Fix some more links

* Modify style changes in sass instead of css

* Edit README.md

* Rename latest to master

Add one-liner install commands (kubeflow#140)

Add one-liner install commands for kubectl & minikube
Ignore .DS_Store files

Fix typo in Seldon component doc (kubeflow#145)

* Update docs for Seldon 0.2 update

* Fix typo in Seldon component doc

Adds sarahmaddox to website OWNERS. (kubeflow#154)

Website guide (kubeflow#143)

* Initial commit of new page.

* Adds more how-to info to the website README.

* Delete gcp-e2e.md

* Separates the doc updating guide into sections

I've added a quickstart which includes a guide to finding the automated preview. I've split out the section on installing Hugo and running a local server, and the guide to a GitHub workflow.

Add links to self-paced scenarios (kubeflow#150)

* Add links to self-paced scenarios

Clarify cluster setup instructions
Remove broken links

* Remove link to example in Requirements

* Add link to Why we use ksonnet

Use correct capitalization on ksonnet components page

Document how to deploy Kubeflow using kfctl. (kubeflow#158)

Added call for UX Research participation. (kubeflow#156)

* Added call for UX Research participation.

* Incorporated jlewi's feedback

Adds context to ksonnet guide and fixes various references (kubeflow#153)

* Fixed references to ksonnet in Troubleshooting guide.

* Fixed references to ksonnet in Requirments guide.

* Added context to the ksonnet guide and fixed references in the getting-started guide.

* Final touches before submitting a PR.

Add getting-started using Microk8s and Multipass (kubeflow#118)

* Add getting-started using Microk8s and Multipass

These instructions are similar to minikube, but
leverage multipass as a native hypervisor solution and
microk8s as the kubernetes installation.

* Fix user-guide URL, add local k8s option details

More information provided on what minikube entails, and what multipass /
microk8s entails.

Add MPI job docs to the website (kubeflow#159)

Add events links (kubeflow#162)

* Add links

Update links to past events and add videos & slides
Add links to upcoming events

* Add origins video & interview with jlewi

* Fix title

* Update start time of video

Add sections to jupyter notebook doc (kubeflow#166)

Split kubeflow-core into individual prototypes (kubeflow#91)

See kubeflow/kubeflow#1207

Update according to new sections

Added a shortcode for minimum required ksonnet version.

Added a shortcode for minimum required Kubernetes version.

Added a link to the Kubernetes version shortcode.
k8s-ci-robot pushed a commit to kubeflow/website that referenced this pull request Aug 30, 2018
@abhi-g @k8s-ci-robot
Sarahmaddox's shortcodes changes (#186)
b1ac9d6 
* Add events links (#162) (#179)

* Add links

Update links to past events and add videos & slides
Add links to upcoming events

* Add origins video & interview with jlewi

* Fix title

* Update start time of video

Add doc on AVX2 and Haswell (#131)

* Add doc on AVX2 and Haswell

* update

* comment

Create S3 documentation for tf-serving (#135)

Slight refactor and inclustion of S3 to our tf-serving docs

Website versioning (#136)

* Add richardsliu to OWNERS in kubeflow/website

* Test website versioning

* Revert "Test website versioning"

This reverts commit 67ea8da.

* Testing website versioning

* Add richardsliu to OWNERS in kubeflow/website

Test website versioning

Revert "Test website versioning"

This reverts commit 67ea8da.

Testing website versioning

* Fix css

* Fixing merge errors

* Fix css

* Fix css

* Fix css

* Fix css

* Change master label to latest

* Parameterize links in docs to point to the right version

* Fix shortcode

* Fix shortcode

* Fix shortcodes

* Fix more links

* Fix some more links

* Modify style changes in sass instead of css

* Edit README.md

* Rename latest to master

Add one-liner install commands (#140)

Add one-liner install commands for kubectl & minikube
Ignore .DS_Store files

Fix typo in Seldon component doc (#145)

* Update docs for Seldon 0.2 update

* Fix typo in Seldon component doc

Adds sarahmaddox to website OWNERS. (#154)

Website guide (#143)

* Initial commit of new page.

* Adds more how-to info to the website README.

* Delete gcp-e2e.md

* Separates the doc updating guide into sections

I've added a quickstart which includes a guide to finding the automated preview. I've split out the section on installing Hugo and running a local server, and the guide to a GitHub workflow.

Add links to self-paced scenarios (#150)

* Add links to self-paced scenarios

Clarify cluster setup instructions
Remove broken links

* Remove link to example in Requirements

* Add link to Why we use ksonnet

Use correct capitalization on ksonnet components page

Document how to deploy Kubeflow using kfctl. (#158)

Added call for UX Research participation. (#156)

* Added call for UX Research participation.

* Incorporated jlewi's feedback

Adds context to ksonnet guide and fixes various references (#153)

* Fixed references to ksonnet in Troubleshooting guide.

* Fixed references to ksonnet in Requirments guide.

* Added context to the ksonnet guide and fixed references in the getting-started guide.

* Final touches before submitting a PR.

Add getting-started using Microk8s and Multipass (#118)

* Add getting-started using Microk8s and Multipass

These instructions are similar to minikube, but
leverage multipass as a native hypervisor solution and
microk8s as the kubernetes installation.

* Fix user-guide URL, add local k8s option details

More information provided on what minikube entails, and what multipass /
microk8s entails.

Add MPI job docs to the website (#159)

Add events links (#162)

* Add links

Update links to past events and add videos & slides
Add links to upcoming events

* Add origins video & interview with jlewi

* Fix title

* Update start time of video

Add sections to jupyter notebook doc (#166)

Split kubeflow-core into individual prototypes (#91)

See kubeflow/kubeflow#1207

Update according to new sections

Added a shortcode for minimum required ksonnet version.

Added a shortcode for minimum required Kubernetes version.

Added a link to the Kubernetes version shortcode.

* Adds a section on shortcodes in the website README.

* Added a bit more about shortcodes to the README.
@pdmack pdmack mentioned this pull request Sep 17, 2018
Closed
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
@k8s-ci-robot
Ambassador refactor (kubeflow#1207)
db595ec 
Jupyterhub refactor

Central Dashboard Refactor

TFJob Refactor

Spartakus

WIP

wip

update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlewi jlewi jlewi requested changes

@wbuchwalter wbuchwalter Awaiting requested review from wbuchwalter

@willingc willingc Awaiting requested review from willingc

@kunmingg kunmingg Awaiting requested review from kunmingg

@lluunn lluunn Awaiting requested review from lluunn

Assignees

@jlewi jlewi

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ankushagarwal @jlewi @k8s-ci-robot