Fix deploy.sh when re-trying on existing deployment name #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankushagarwal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jlewi
added a commit
to jlewi/kubeflow
that referenced
this pull request
Sep 4, 2018
* We need to cd to the directory containing the deployment manager configs before issuing gcloud deployment-manager update * It works when the deployment doesn't exist because in that case we execute a code block that cd's to the directory. * Looks like previous fix kubeflow#1243 never got cherrypicked onto 0.2 branch. * Fix kubeflow#1233
jlewi
added a commit
that referenced
this pull request
Sep 4, 2018
* We need to cd to the directory containing the deployment manager configs before issuing gcloud deployment-manager update * It works when the deployment doesn't exist because in that case we execute a code block that cd's to the directory. * Looks like previous fix #1243 never got cherrypicked onto 0.2 branch. * Fix #1233
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
yanniszark
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Feb 15, 2021
* Add spec.parameters validation * Fix print * Change parameter index in test * Change reflect to equality.Semantic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1233
/cc @jlewi
/cc @ankushagarwal
This change is