Fix bug with updating an existing deployment. #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We need to cd to the directory containing the deployment manager configs before issuing gcloud deployment-manager update * It works when the deployment doesn't exist because in that case we execute a code block that cd's to the directory. * Looks like previous fix kubeflow#1243 never got cherrypicked onto 0.2 branch. * Fix kubeflow#1233
|
/assign @ankushagarwal |
|
@jlewi: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm
/approve
On Tue, Sep 4, 2018 at 3:33 PM k8s-ci-robot ***@***.***> wrote:
@jlewi <https://github.com/jlewi>: The following test *failed*, say
/retest to rerun them all:
Test name Commit Details Rerun command
kubeflow-presubmit 6dab6ad
<6dab6ad>
link
<https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/kubeflow_kubeflow/1475/kubeflow-presubmit/3211/> /test
kubeflow-presubmit
Full PR test history
<https://k8s-gubernator.appspot.com/pr/kubeflow_kubeflow/1475>. Your PR
dashboard <https://k8s-gubernator.appspot.com/pr/jlewi>. Please help us
cut down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubeflow/kubeflow/issues?q=is:issue+is:open> when you
hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#1475 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAwpFVpOQhgNuPRP79BRjfsgfLIL0uoDks5uXv-wgaJpZM4WZ3ri>
.
--
Ankush Agarwal
Software Engineer, Cloud ML
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankushagarwal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Ignoring the test failures per |
surajkota
pushed a commit
to surajkota/kubeflow
that referenced
this pull request
Jun 13, 2022
…ubeflow#1475) * image gcr.io/kubeflow-images-public/jupyter-web-app:vmaster-g845af298 * Image built from kubeflow/kubeflow@845af298
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to cd to the directory containing the deployment manager configs
before issuing gcloud deployment-manager update
It works when the deployment doesn't exist because in that case we execute
a code block that cd's to the directory.
Looks like previous fix Fix deploy.sh when re-trying on existing deployment name #1243 never got cherrypicked onto 0.2 branch.
Fix scripts/gke/deploy.sh fails when kubeflow_deployment_manager_configs/ exists #1233
This change is