The minikube test should not be running the jsonnet unittests. #1545
Conversation
* jsonnet unittests are now run by a separate E2E workflow. * The jsonnet tests when run as part of minikube were failing because they were not updated as part of kubeflow#1437 * Fix kubeflow#1543 failing postsubmits.
| "testing.test_jsonnet", | ||
| "--artifacts_dir=" + artifactsDir, | ||
| "--test_files_dirs=" + srcDir + "/kubeflow", | ||
| "--jsonnet_path_dirs=" + srcDir, |
There was a problem hiding this comment.
Do we need --jsonnet_path_dirs=" + srcDir + "," + srcRootDir + "/kubeflow/testing/workflows/lib/v1.7.0"
There was a problem hiding this comment.
Not in this file. This Argo workflow should not be running the jsonnet tests.
We use unit_tests.jsonnet workflow to run the jsonnet unittests and you already updated that file to set jsonnet_path_dirs
https://github.com/kubeflow/kubeflow/blob/master/testing/workflows/components/unit_tests.jsonnet#L116
|
Test failure looks like a flake with the argo test; There is an issue to try to make this test more robust; |
|
/test all |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pdmack The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…low#1545) * jsonnet unittests are now run by a separate E2E workflow. * The jsonnet tests when run as part of minikube were failing because they were not updated as part of kubeflow#1437 * Fix kubeflow#1543 failing postsubmits.
jsonnet unittests are now run by a separate E2E workflow.
The jsonnet tests when run as part of minikube were failing because they
were not updated as part of standardize remaining <component>.{jsonnet,libsonnet} files #1437
Fix test_jsonnet is failing in postsubmit #1543 failing postsubmits.
This change is