Skip to content

Commit

Permalink
The minikube test should not be running the jsonnet unittests. (kubef…
Browse files Browse the repository at this point in the history
…low#1545)

* jsonnet unittests are now run by a separate E2E workflow.
* The jsonnet tests when run as part of minikube were failing because they
  were not updated as part of kubeflow#1437

* Fix kubeflow#1543 failing postsubmits.
  • Loading branch information
jlewi authored and k8s-ci-robot committed Sep 17, 2018
1 parent 3b1394a commit e93e2c3
Showing 1 changed file with 0 additions and 27 deletions.
27 changes: 0 additions & 27 deletions testing/workflows/components/workflows.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -482,11 +482,6 @@
template: "create-pr-symlink",
dependencies: ["checkout"],
},
{
name: "test-jsonnet-formatting",
template: "test-jsonnet-formatting",
dependencies: ["checkout"],
},
{
name: "deploy-kubeflow",
template: "deploy-kubeflow",
Expand Down Expand Up @@ -530,11 +525,6 @@
"deploy-kubeflow",
],
},
{
name: "jsonnet-test",
template: "jsonnet-test",
dependencies: ["checkout"],
},
]), // tasks
}, // dag
}, // e2e template
Expand Down Expand Up @@ -592,15 +582,6 @@
"-m",
"testing.wait_for_deployment",
]), // wait-for-kubeflow
buildTemplate("test-jsonnet-formatting", [
"python",
"-m",
"kubeflow.testing.test_jsonnet_formatting",
"--project=" + project,
"--artifacts_dir=" + artifactsDir,
"--src_dir=" + srcDir,
"--exclude_dirs=" + srcDir + "/bootstrap/vendor/",
]), // test-jsonnet-formatting
// Setup and teardown using minikube
buildTemplate("setup-minikube", [
"python",
Expand Down Expand Up @@ -652,14 +633,6 @@
"copy_artifacts",
"--bucket=" + bucket,
]), // copy-artifacts
buildTemplate("jsonnet-test", [
"python",
"-m",
"testing.test_jsonnet",
"--artifacts_dir=" + artifactsDir,
"--test_files_dirs=" + srcDir + "/kubeflow",
"--jsonnet_path_dirs=" + srcDir,
]), // jsonnet-test
buildTemplate("tfjob-simple-prototype-test", [
"python",
"-m",
Expand Down

0 comments on commit e93e2c3

Please sign in to comment.