Seldon ksonnet refactor #1752
Merged
Seldon ksonnet refactor #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @jlewi |
|
/lgtm |
|
Most recent test flake is "failed to get container status" #1620 |
|
Looks like the error is |
|
The init phase failed to get a supported version This is fixed by #1747 @cliveseldon could you please rebase off master and rerun the tests? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
leoncamel
pushed a commit
to leoncamel/kubeflow
that referenced
this pull request
Oct 14, 2018
* Update seldon ksonnet so almost same as seldon-core repo * update README for ksonnet json construction for seldon * Updated seldon prototypes * reformat jsonnet
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
* Update seldon ksonnet so almost same as seldon-core repo * update README for ksonnet json construction for seldon * Updated seldon prototypes * reformat jsonnet
surajkota
pushed a commit
to surajkota/kubeflow
that referenced
this pull request
Jun 13, 2022
… dir. Fixes kubeflow#4530 kubeflow/pipelines (kubeflow#1752) * Updated to make possible to evict pods even with empty dir * fixed missing change * moved annotation * clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the ksonnet code almost identical to that which is in the core project seldon-core
Also:
Ambassador json is in the code but is defaulted to false as obviously Kubeflow has Ambassador installation separately.
This change is