Ensure namespace exists #1747
Merged
Ensure namespace exists #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We need to call createNamespace during the apply phase for k8s otherwise the namespace might not exist. Need to patch into 0.3
|
/assign @richardsliu |
|
Test failed I thought kfctl was changed to call get-server-config? |
|
Looks like we should be doing it here Line 99 in 84020a3 |
|
Looks like it failed during the init step |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardsliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jlewi
added a commit
to jlewi/kubeflow
that referenced
this pull request
Oct 12, 2018
* Ensure namespace exists * We need to call createNamespace during the apply phase for k8s otherwise the namespace might not exist. Need to patch into 0.3 * Fix get-server-config; it was failing because ZONE wasn't being set. * Run gcloud as a separate command so that if it errors out the script will fail. * * Fix bug in updateDeployment we should be using NAME not DEPLOYMENT_NAME
k8s-ci-robot
pushed a commit
that referenced
this pull request
Oct 12, 2018
* Pin jupyter-console to 0.6.0 (#1746) * Ensure namespace exists (#1747) * Ensure namespace exists * We need to call createNamespace during the apply phase for k8s otherwise the namespace might not exist. Need to patch into 0.3 * Fix get-server-config; it was failing because ZONE wasn't being set. * Run gcloud as a separate command so that if it errors out the script will fail. * * Fix bug in updateDeployment we should be using NAME not DEPLOYMENT_NAME
This was referenced Oct 12, 2018
leoncamel
pushed a commit
to leoncamel/kubeflow
that referenced
this pull request
Oct 14, 2018
* Ensure namespace exists * We need to call createNamespace during the apply phase for k8s otherwise the namespace might not exist. Need to patch into 0.3 * Fix get-server-config; it was failing because ZONE wasn't being set. * Run gcloud as a separate command so that if it errors out the script will fail. * * Fix bug in updateDeployment we should be using NAME not DEPLOYMENT_NAME
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
* Ensure namespace exists * We need to call createNamespace during the apply phase for k8s otherwise the namespace might not exist. Need to patch into 0.3 * Fix get-server-config; it was failing because ZONE wasn't being set. * Run gcloud as a separate command so that if it errors out the script will fail. * * Fix bug in updateDeployment we should be using NAME not DEPLOYMENT_NAME
surajkota
pushed a commit
to surajkota/kubeflow
that referenced
this pull request
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise the namespace might not exist.
Need to patch into 0.3
Related to #1675
This change is