fixes 'Move components in core into a GCP specific ksonnet package' #2043
Conversation
|
/assign @jlewi |
|
/assign @kunmingg |
kubeflow/gcp/OWNERS
Outdated
| @@ -0,0 +1,3 @@ | |||
| approvers: | |||
| - gaocegege | |||
There was a problem hiding this comment.
Not the right set of approvers for GCP :)
Please list Googlers
jlewi, r2d4, richardsliu, kunming, llunnn, abhi-g
There was a problem hiding this comment.
my bad, i didn't realize that's where you look
There was a problem hiding this comment.
Can you remove gaocegege please?
|
Thanks so much. For doing this @kkasravi Test is likely failing because you need to update kfctl |
|
/assign @r2d4 |
|
/assign @kunmingg |
kubeflow/gcp/OWNERS
Outdated
| @@ -0,0 +1,3 @@ | |||
| approvers: | |||
| - gaocegege | |||
| reviewers: | |||
There was a problem hiding this comment.
If there are new reviewers just remove the reviewers section.
|
looks like the OWNERs file might still need to be updated. |
|
@jlewi OWNERs file should be good now |
|
/retest |
|
@kkasravi Can you remove gaocegege as an approver since this is GCP specific? |
|
/retest |
1 similar comment
|
/retest |
|
/test all |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ubeflow#2043) * fixes 'Move components in core into a GCP specific ksonnet package' * remove gcp related packages from core * /retest * update approvers and reviewers * remove gaocegege
fixes #1996
This change is