Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deprecation Notice to README of openmpi package #2127

Merged
merged 1 commit into from Jan 22, 2019

Conversation

everpeace
Copy link
Contributor

@everpeace everpeace commented Dec 19, 2018

As discussed in #778 (comment), we will eventually remove openmpi package at 0.5.0 (#1859).

I put a deprecation notice to README of openmpi package to resolve the issue (kubeflow/website#272)


This change is Reviewable

@everpeace
Copy link
Contributor Author

/assign @jlewi
Please take a look.

@alsrgv
Copy link

alsrgv commented Dec 19, 2018

LGTM, MPI operator is great!
/approve

@jlewi
Copy link
Contributor

jlewi commented Dec 19, 2018

Thanks!
/test all
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alsrgv, jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@everpeace
Copy link
Contributor Author

/retest

@jlewi
Copy link
Contributor

jlewi commented Dec 20, 2018

Test failures:
#2142 test_runner complaining about improper usage; is it a flake?
kubeflow/testing#229 - minikube shouldn't have been triggered

/test all

@jlewi
Copy link
Contributor

jlewi commented Dec 27, 2018

/test all

@jlewi
Copy link
Contributor

jlewi commented Dec 28, 2018

I submitted a fix for improper triggering of tests (kubeflow/testing#229).
Hopefully that fixes the test failures.

/test all

@jlewi
Copy link
Contributor

jlewi commented Dec 28, 2018

minikube test wasn't triggered but it looks like the studyjobcontroller deploy test failed.

@jlewi
Copy link
Contributor

jlewi commented Jan 7, 2019

/test all

@jlewi
Copy link
Contributor

jlewi commented Jan 7, 2019

If the tests don't pass I'll merge this manually since its just a docs change.

@k8s-ci-robot
Copy link
Contributor

@everpeace: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubeflow-presubmit caa2842 link /test kubeflow-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jlewi jlewi merged commit ccb28a5 into kubeflow:master Jan 22, 2019
kkasravi pushed a commit to kkasravi/kubeflow that referenced this pull request Feb 8, 2019
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants