Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use command array in mpi job prototype #2434

Merged
merged 1 commit into from Feb 13, 2019

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Feb 8, 2019

Meet this problem when I yaml.Unmarshal(manifest, &mpiJob)

error unmarshaling JSON: while decoding JSON: json: cannot unmarshal string into Go struct field Container.command of type []string"

MPI job spec template uses corev1.PodTemplateSpec. Commands and Args are both []string type.

https://github.com/kubernetes/api/blob/369c77d0cd027d5cb8eebabebfb64d38b21538a0/core/v1/types.go#L2065-L2080


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @Jeffwan. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jeffwan
Copy link
Member Author

Jeffwan commented Feb 10, 2019

/cc @everpeace

Copy link
Contributor

@everpeace everpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

@Jeffwan
Copy link
Member Author

Jeffwan commented Feb 11, 2019

/assign @jlewi

@jlewi
Copy link
Contributor

jlewi commented Feb 11, 2019

/ok-to-test
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jeffwan
Copy link
Member Author

Jeffwan commented Feb 12, 2019

deploy-kubeflow-test_katib-test-katib 2m4s. Not related to PR
/test kubeflow-presubmit

@Jeffwan
Copy link
Member Author

Jeffwan commented Feb 12, 2019

Looks like it experience Quota limitation error.
/test kubeflow-presubmit

@jlewi
Copy link
Contributor

jlewi commented Feb 12, 2019

Looks like we ran out of disk space in our ci cluster.

+ gcloud deployment-manager --project=kubeflow-ci deployments update kfctl-2ba2-storage --config=storage-kubeflow.yaml
kfctl-2ba2 exists
The fingerprint of the deployment is TdfAv7dn-hCn7VBqJgxl7Q==
Waiting for update [operation-1549956839590-581ad72d74c4e-dd513b89-df67252d]...
.......failed.
ERROR: (gcloud.deployment-manager.deployments.update) Error in Operation [operation-1549956839590-581ad72d74c4e-dd513b89-df67252d]: errors:
- code: RESOURCE_ERROR
 location: /deployments/kfctl-2ba2-storage/resources/kfctl-2ba2-storage-pipeline-nfs
 message: "{\"ResourceType\":\"compute.v1.disk\",\"ResourceErrorCode\":\"403\",\"\
   ResourceErrorMessage\":{\"code\":403,\"errors\":[{\"domain\":\"usageLimits\",\"\
   message\":\"Quota 'DISKS_TOTAL_GB' exceeded. Limit: 16384.0 in region us-east1.\"\
   ,\"reason\":\"quotaExceeded\"}],\"message\":\"Quota 'DISKS_TOTAL_GB' exceeded.\
   \ Limit: 16384.0 in region us-east1.\",\"statusMessage\":\"Forbidden\",\"requestPath\"\
   :\"https://www.googleapis.com/compute/v1/projects/kubeflow-ci/zones/us-east1-d/disks\"\
   ,\"httpMethod\":\"POST\"}}"

/test all

@jlewi
Copy link
Contributor

jlewi commented Feb 12, 2019

Related issue: #388

@Jeffwan
Copy link
Member Author

Jeffwan commented Feb 12, 2019

/test kubeflow-presubmit

Have another try

@jlewi
Copy link
Contributor

jlewi commented Feb 13, 2019

/test all

@k8s-ci-robot k8s-ci-robot merged commit e152a79 into kubeflow:master Feb 13, 2019
kimwnasptd pushed a commit to arrikto/kubeflow that referenced this pull request Feb 13, 2019
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants