New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use command array in mpi job prototype #2434
Conversation
Hi @Jeffwan. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @everpeace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me.
/assign @jlewi |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deploy-kubeflow-test_katib-test-katib 2m4s. Not related to PR |
Looks like it experience Quota limitation error. |
Looks like we ran out of disk space in our ci cluster.
/test all |
Related issue: #388 |
/test kubeflow-presubmit Have another try |
/test all |
Meet this problem when I
yaml.Unmarshal(manifest, &mpiJob)
MPI job spec template uses corev1.PodTemplateSpec. Commands and Args are both
[]string
type.https://github.com/kubernetes/api/blob/369c77d0cd027d5cb8eebabebfb64d38b21538a0/core/v1/types.go#L2065-L2080
This change is