Deploy NFS only when explicitly set the nfs parameter #2446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @jlewi |
|
/test kubeflow-presubmit |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kimwnasptd
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Feb 13, 2019
IronPan
added a commit
to IronPan/kubeflow
that referenced
this pull request
Feb 13, 2019
k8s-ci-robot
pushed a commit
that referenced
this pull request
Feb 14, 2019
* sync pipelines branch to master * add pipeline team to the owner file (#2299) * add pipeline team to the owner file * Update OWNERS * fix * Specify CRD version using v1beta1 schema (#2424) * Bump pipeline version to 0.1.9 (#2427) * deploy storage through kfctl.sh (#2373) * deploy storage through kfctl.sh * revert the change to delete storage DM * propagate feature flag * skip set param conditionally * avoid exposing permanent storage as high level flag * delete storage in test * update test template * add quite * delete storage after cluster deletion * Wait for at most 100s on namespace deletion (#2409) * delete namespace conditionally * delete namespace conditionally * address comments * Update kfctl.sh * fix * fix (#2446) * Deploy viewer CRD controller for Kubeflow Pipelines. (#2416) * Deploy viewer CRD controller for Kubeflow Pipelines. * Add missing image variable * Use new schema to specify versions. * Reduce NFS disk size from 200 -> 20 GB (#2464) Since the corresponding PVC only need 20Gb. /assign @kunmingg * add selector for minio deploy (#2466)
k8s-ci-robot
pushed a commit
that referenced
this pull request
Feb 25, 2019
* sync pipelines branch to master * add pipeline team to the owner file (#2299) * add pipeline team to the owner file * Update OWNERS * fix * Specify CRD version using v1beta1 schema (#2424) * Bump pipeline version to 0.1.9 (#2427) * deploy storage through kfctl.sh (#2373) * deploy storage through kfctl.sh * revert the change to delete storage DM * propagate feature flag * skip set param conditionally * avoid exposing permanent storage as high level flag * delete storage in test * update test template * add quite * delete storage after cluster deletion * Wait for at most 100s on namespace deletion (#2409) * delete namespace conditionally * delete namespace conditionally * address comments * Update kfctl.sh * fix * fix (#2446) * Deploy viewer CRD controller for Kubeflow Pipelines. (#2416) * Deploy viewer CRD controller for Kubeflow Pipelines. * Add missing image variable * Use new schema to specify versions. * Reduce NFS disk size from 200 -> 20 GB (#2464) Since the corresponding PVC only need 20Gb. /assign @kunmingg * add selector for minio deploy (#2466) * merge * default to minio (#2503) * Add script to upgrade kubeflow pipeline (#2479) * create default environment during step * add script to upgrade pipeline * polish script * add ks apply * address comment * update script * update pipeline image version to v0.1.10 (#2534)
jlewi
pushed a commit
that referenced
this pull request
Mar 26, 2019
* sync pipelines branch to master * add pipeline team to the owner file (#2299) * add pipeline team to the owner file * Update OWNERS * fix * Specify CRD version using v1beta1 schema (#2424) * Bump pipeline version to 0.1.9 (#2427) * deploy storage through kfctl.sh (#2373) * deploy storage through kfctl.sh * revert the change to delete storage DM * propagate feature flag * skip set param conditionally * avoid exposing permanent storage as high level flag * delete storage in test * update test template * add quite * delete storage after cluster deletion * Wait for at most 100s on namespace deletion (#2409) * delete namespace conditionally * delete namespace conditionally * address comments * Update kfctl.sh * fix * fix (#2446) * Deploy viewer CRD controller for Kubeflow Pipelines. (#2416) * Deploy viewer CRD controller for Kubeflow Pipelines. * Add missing image variable * Use new schema to specify versions. * Reduce NFS disk size from 200 -> 20 GB (#2464) Since the corresponding PVC only need 20Gb. /assign @kunmingg * add selector for minio deploy (#2466) * merge * default to minio (#2503) * Add script to upgrade kubeflow pipeline (#2479) * create default environment during step * add script to upgrade pipeline * polish script * add ks apply * address comment * update script * update pipeline image version to v0.1.10 (#2534) * update pipeline version to v0.1.13 (#2783) /assign @neuromage * sync pipelines branch to master * revert * update * update * sync
jlewi
pushed a commit
that referenced
this pull request
Apr 2, 2019
* sync pipelines branch to master * add pipeline team to the owner file (#2299) * add pipeline team to the owner file * Update OWNERS * fix * Specify CRD version using v1beta1 schema (#2424) * Bump pipeline version to 0.1.9 (#2427) * deploy storage through kfctl.sh (#2373) * deploy storage through kfctl.sh * revert the change to delete storage DM * propagate feature flag * skip set param conditionally * avoid exposing permanent storage as high level flag * delete storage in test * update test template * add quite * delete storage after cluster deletion * Wait for at most 100s on namespace deletion (#2409) * delete namespace conditionally * delete namespace conditionally * address comments * Update kfctl.sh * fix * fix (#2446) * Deploy viewer CRD controller for Kubeflow Pipelines. (#2416) * Deploy viewer CRD controller for Kubeflow Pipelines. * Add missing image variable * Use new schema to specify versions. * Reduce NFS disk size from 200 -> 20 GB (#2464) Since the corresponding PVC only need 20Gb. /assign @kunmingg * add selector for minio deploy (#2466) * merge * default to minio (#2503) * Add script to upgrade kubeflow pipeline (#2479) * create default environment during step * add script to upgrade pipeline * polish script * add ks apply * address comment * update script * update pipeline image version to v0.1.10 (#2534) * sync to v0.5.0-rc.1
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NFS will be deployed only when explicitly set nfsPvName or nfsPd.
By default NFS won't be deployed. Minio will use minioPvName, minioPd or PVC provisioned by default storageclass.
fix #2443
This change is