New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
name the PD generically and assign to minio #2503
Conversation
/assign @kunmingg |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kunmingg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test kubeflow-presubmit |
1 similar comment
/test kubeflow-presubmit |
* sync pipelines branch to master * add pipeline team to the owner file (#2299) * add pipeline team to the owner file * Update OWNERS * fix * Specify CRD version using v1beta1 schema (#2424) * Bump pipeline version to 0.1.9 (#2427) * deploy storage through kfctl.sh (#2373) * deploy storage through kfctl.sh * revert the change to delete storage DM * propagate feature flag * skip set param conditionally * avoid exposing permanent storage as high level flag * delete storage in test * update test template * add quite * delete storage after cluster deletion * Wait for at most 100s on namespace deletion (#2409) * delete namespace conditionally * delete namespace conditionally * address comments * Update kfctl.sh * fix * fix (#2446) * Deploy viewer CRD controller for Kubeflow Pipelines. (#2416) * Deploy viewer CRD controller for Kubeflow Pipelines. * Add missing image variable * Use new schema to specify versions. * Reduce NFS disk size from 200 -> 20 GB (#2464) Since the corresponding PVC only need 20Gb. /assign @kunmingg * add selector for minio deploy (#2466) * merge * default to minio (#2503) * Add script to upgrade kubeflow pipeline (#2479) * create default environment during step * add script to upgrade pipeline * polish script * add ks apply * address comment * update script * update pipeline image version to v0.1.10 (#2534)
* sync pipelines branch to master * add pipeline team to the owner file (#2299) * add pipeline team to the owner file * Update OWNERS * fix * Specify CRD version using v1beta1 schema (#2424) * Bump pipeline version to 0.1.9 (#2427) * deploy storage through kfctl.sh (#2373) * deploy storage through kfctl.sh * revert the change to delete storage DM * propagate feature flag * skip set param conditionally * avoid exposing permanent storage as high level flag * delete storage in test * update test template * add quite * delete storage after cluster deletion * Wait for at most 100s on namespace deletion (#2409) * delete namespace conditionally * delete namespace conditionally * address comments * Update kfctl.sh * fix * fix (#2446) * Deploy viewer CRD controller for Kubeflow Pipelines. (#2416) * Deploy viewer CRD controller for Kubeflow Pipelines. * Add missing image variable * Use new schema to specify versions. * Reduce NFS disk size from 200 -> 20 GB (#2464) Since the corresponding PVC only need 20Gb. /assign @kunmingg * add selector for minio deploy (#2466) * merge * default to minio (#2503) * Add script to upgrade kubeflow pipeline (#2479) * create default environment during step * add script to upgrade pipeline * polish script * add ks apply * address comment * update script * update pipeline image version to v0.1.10 (#2534) * update pipeline version to v0.1.13 (#2783) /assign @neuromage * sync pipelines branch to master * revert * update * update * sync
* sync pipelines branch to master * add pipeline team to the owner file (#2299) * add pipeline team to the owner file * Update OWNERS * fix * Specify CRD version using v1beta1 schema (#2424) * Bump pipeline version to 0.1.9 (#2427) * deploy storage through kfctl.sh (#2373) * deploy storage through kfctl.sh * revert the change to delete storage DM * propagate feature flag * skip set param conditionally * avoid exposing permanent storage as high level flag * delete storage in test * update test template * add quite * delete storage after cluster deletion * Wait for at most 100s on namespace deletion (#2409) * delete namespace conditionally * delete namespace conditionally * address comments * Update kfctl.sh * fix * fix (#2446) * Deploy viewer CRD controller for Kubeflow Pipelines. (#2416) * Deploy viewer CRD controller for Kubeflow Pipelines. * Add missing image variable * Use new schema to specify versions. * Reduce NFS disk size from 200 -> 20 GB (#2464) Since the corresponding PVC only need 20Gb. /assign @kunmingg * add selector for minio deploy (#2466) * merge * default to minio (#2503) * Add script to upgrade kubeflow pipeline (#2479) * create default environment during step * add script to upgrade pipeline * polish script * add ks apply * address comment * update script * update pipeline image version to v0.1.10 (#2534) * sync to v0.5.0-rc.1
Name the PD generically to avoid future renaming
Also assign PDs to minio to skip creating nfs by default
This change is