Add status to notebook #2558

lluunn · 2019-02-26T21:42:43Z

Add status condition "Ready" to notebook CR if no error
e2e test verifies condition
some refactoring

This change is

lluunn · 2019-02-28T18:01:38Z

/retest

lluunn · 2019-03-01T01:22:08Z

/retest

lluunn · 2019-03-01T01:48:50Z

ready for review
/assign @jlewi @kkasravi @richardsliu

jlewi · 2019-03-01T16:30:57Z

@richardsliu Do you mind taking this review?

richardsliu · 2019-03-04T19:49:00Z

components/notebook-controller/pkg/controller/notebook/notebook_controller.go

+
+	// Update the status if previous condition is not "Ready"
+	oldConditions := instance.Status.Conditions
+	if len(oldConditions) == 0 || oldConditions[0].Type != "Ready" {


Is the last condition at index 0 or -1?

I am doing prepending, (line 188), so should be 0.
I think prepending is convention, e.g. https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/deployment/util/deployment_util.go#L136

richardsliu · 2019-03-04T19:50:37Z

kubeflow/jupyter/notebook_controller.libsonnet

@@ -23,6 +23,14 @@
          kind: "Notebook",
        },
      },
+      status: {


Consider using subresource status and then calling UpdateStatus(): kubeflow/training-operator#939

This prevents bugs where the previous status is unexpectedly overwritten as a result of an update.

we are using status subresource. see line 17

richardsliu · 2019-03-04T21:27:30Z

/lgtm
/approve

k8s-ci-robot · 2019-03-04T21:27:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [richardsliu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lluunn · 2019-03-04T21:58:57Z

Error: gcloud auth activate-service-account failed

lluunn · 2019-03-04T22:08:50Z

/retest

kunmingg · 2019-03-04T22:27:10Z

components/notebook-controller/pkg/controller/notebook/notebook_controller.go

 		return reconcile.Result{}, err
 	}
+	// Update the foundStateful object and write the result back if there are any changes
+	if !justCreated && util.CopyStatefulSetFields(ss, foundStateful) {


What if StatefulSet with name ss.Name already exist in the namespace and is created by other user / service?

I think the reconcile will then fail, which is the intended behavior?

Ideally we should fail it and add message to status explaining why it fails.
Seems currently controller will just update StatefulSet?

I think it will fail because we can't claim ownership on that statefulset.

* wip * wip * update test to check status condition * fix

@prodonjs

…forms' (#2547) * revert to prior version * fixes kfctl (golang) rename 'ks' directory and app to ksonnet and ksonnet.go respectively * fixes 'kfctl - Fetch registry automatically' * fixes 'refactor gcp, minikube, docker-for-desktop, ack to be kfctl plugins' * change DefaultDevRepo to point to just the repo not repo/kubeflow * fixes 'refactor gcp, minikube, docker-for-desktop, ack to be kfctl plugins' * plugins for all existing KfApp instances {ksonnet, minikube, foo}. * update golang version * fixes 'docker-for-desktop' * delete meta-controller-cluster-role-binding * update README.md * remove unused var DEBUG * remove bootstrap/cmd/plugins/foo.go * fixes kfctl (golang) rename 'ks' directory and app to ksonnet and ksonnet.go respectively * fixes 'add the gcp platform to kfctl (golang)' * fix merge conflict * cli option --project is an init flag * fix to write out project to app.yaml * fix for nil project check * include fix for #2367 * added updateDM, createSecrets to Apply * fixes to macros * merge changes from upstream master * remove old files, update README.md * fix for init app-name where app-name is not a path * fix for gcp apply * code to create a Gcp Secret, doesn't do correct auth right now * snapshot * update on downloadK8sManifests, gcpInitProject, added TODO's * additional work on gcpInitProject * gcpInitProject now works but requires GOOGLE_APPLICATION_CREDENTIALS env var * initial pass on updateDeployment * update README.md to described static vs dynamic platforms * updates to Gcp.updateDM, added GOOGLE_APPLICATION_CREDENTIALS to the Makefile tests * minor changes on init, generate usage * snapshot * additional global resources identified * do not delete scalingpolicies * change default platform to ksonnet * default --version to master until 0.5.0 * remove verbose from spark-operator apply * address comments from Jeremy * address comments from Jeremy * fixes #2537, refer to no platform as 'none' * add general test for kfctl in Makefile that also tests the plugin capability * remove kftcl config since we now have bootstrap config, fix for DefaultPlatform="none" * change test of platform none to create directory none, updated README * remove reference to docker-for-desktop * update README.md, remove --debug flag (not used) * fixes 'kfctl (golang) Simplify the child/parent relationships in platforms' * fix backendconfig name (#2542) * fix backendconfig name * fix test * pin to the latest verified tf-operator commit in order to enable changes in tf-operator HEAD whcih likely break kubeflow checkout tests * fix (#2506) * Added unit tests for GetUpdatedPolicy at gcpUtils.go - bootstrap/app (#2516) * Added tests for 'GetUpdatedPolicy' - bootstrap/app * Fix typo - gcpUtils_test.go * Added a windows equivalent script for the makefile for central-dashboard (#2518) * update katib component (#2553) * Refactor for Express + Webpack build stack. (#2572) * Refactor for Express + Webpack build stack. - Add webpack to process front-end code in public/ - Add TS and Express for server backend - Update Dockerfile to run the server as Node. - Fix issue with external links. * Updates based on feedback * address review comments * move tests under test directory * Add ESLint to enforce Google JS style in public/ (#2579) * Add ESLint to enforce Google JS style in public/ * Switch to 4 space tabs * Updating python package imports related to tf-operator (#2581) * updated tf-operator imports * fixed a typo * fixed a typo * Profiles e2e test (#2404) * profiles e2e test * fix * review comment * fix * fix * fix * fix * add retry * fix * Update the jupyter-web-app Image (#2589) Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * Golang profile controller (#2533) * init * create api * wip * fix * fix * fix * fix test * address review * fix test * make it cluster scope * fix test * fix test * fix * turnoff jupyter images authentication (#2591) * Updated Jupyter image paths for using in notebook controller (#2552) * updated jupyter image paths for using in notebook conroller * removed 1.4.1 image from the list of options * updated jupyter image tags to point to the latest verified ones * updated jupyter images to allow any origin (#2606) * Removing prune for Subresource field in CRD (#2598) * Adding backOffLimit field to metric collector spec (#2597) * remove global resources by label rather than listing all and looking for the label * mv client to coordinator * Fixed Dashboard v0.0.1 w/ Polymer3 + Webpack (#2576) * Multiple issues tackled: - Fixed webpack for windows (components/ is not a valid path in windows) - Spacing and semicolons matched to old-codebase - Added cross-platform support to npm run targets - Added missing dep (babel/polyfill) - Dashboard build version is now corrected and hover will reveal kubeflow vs Dashboard versions - Pug fixed to match syntax for empty-value attributes - Updated webpack for readability * Added babel-polyfill to runtime deps rather than dev deps * [Windows-only] Color coded all make output, Tag check added, failures now have messages, also dirty git output now has a warning during build * Updated new dashboard reference :v20190227-v0.4.0-rc.1-176-g738de035 * Fixed Multiple changes: - Server port fixed to 8082 which is what is needed for GKE deployment - Refactored some code * Final working state for new image * TS Changes * Build updated to match latest :v20190301-v0.4.0-rc.1-183-g07eecd2f * Migrated dev dependency to correct location * Uncommented linter, fixed PR comments from @prodonjs * updated jupyter images based on postsubmit results of 97b94c0 (#2611) * Adding additional printer columns to display status (#2609) * Adding additional printer columns to display status * Fixing tests * Semi-working kfctl go binary (#2587) * Add flag --skip-init-gcp-project * fix gcpInitProject * update error msg * add deployment creation logic * fix bugs on generateDMData * fix bugs * add default config to ipName and hostName * fix bugs on app.yaml * add Fingerprint to update deployment * make network and gcfs as DM optional * add todos * add iam policy handlers * finish patch iam policy * adding poll op to dm api calls * add gke api version * temp * change mysqlPd/nfsPd names * remove * temp * add config types * add basic auth flag * move config to gcp * link use basic auth flag to generate * use basic auth to determine config path * change to gabrielwen repo for now * change config on the fly * change repo path * create new Genereate method * add required packages * implement NewGenerate * clean up default config and add on-the-fly configs * move config handling to ksonnet.go * add ks param set * add application as component * fix typo * add simple TargetConfiguration factory * add fixed backof * temp * fix from merge * make namespace in gke * bind user as default-admin in gke * finish createSecrets * write oauth secret * uncomment ks apply * add ks show * add ks apply logic to k8sutils * uncomment deployment * build rest.Config from remote * impersonate as admin for rbac * use remote config as REST client config * update default.yaml path * complete apply logic * add retry * add ignore * merge * remove temp comment * use backoff in gcp * remove progress as it is not updating * use backoff * use backoff * use default zone * fix zone config * add doc * add doc * update Makefile * fix flag doc * fix * doc * doc * add doc * sort packages and component names * shell out to gcloud and kubectl for now * remove some configs * fix * remove GkeApiVersion * add todo * add notebook-controller back * change names * updates * add field InitRequired * remove KsInitParams * migrate * Add status to notebook (#2558) * wip * wip * update test to check status condition * fix * Add prodonjs to OWNERS (#2613) * Changed sidebar tab from JupyterHub to Notebooks (#2619) * fix (#2620) * pf gcb (#2603) * Setting the base_url flag of Jupyter images (#2627) * set base_url of jupyter * change the env base_url to NB_PREFIX to sync with #2620 * fix (#2631) * resolve merge conflicts from upstream/master, fix error on master when --platform=none or not specified * store non exist parameter differently (#2625) * fix (#2632) * update pipeline system images to 0.1.12 release (#2637) * updated jupyter image paths to point to the latest ones (#2638) * add retry around ks init (#2643) * add retry around ks init * update comments * merge errors * Getting started card completed (#2651) * Getting Started card content added, and un-hidden. Windows support added in webpack to run dev builds * Getting Started card fully implemented from mocks * Spaced out cards a little more * Got eslint working! And fixed eslint issues in webpack

@prodonjs

…forms' (kubeflow#2547) * revert to prior version * fixes kfctl (golang) rename 'ks' directory and app to ksonnet and ksonnet.go respectively * fixes 'kfctl - Fetch registry automatically' * fixes 'refactor gcp, minikube, docker-for-desktop, ack to be kfctl plugins' * change DefaultDevRepo to point to just the repo not repo/kubeflow * fixes 'refactor gcp, minikube, docker-for-desktop, ack to be kfctl plugins' * plugins for all existing KfApp instances {ksonnet, minikube, foo}. * update golang version * fixes 'docker-for-desktop' * delete meta-controller-cluster-role-binding * update README.md * remove unused var DEBUG * remove bootstrap/cmd/plugins/foo.go * fixes kfctl (golang) rename 'ks' directory and app to ksonnet and ksonnet.go respectively * fixes 'add the gcp platform to kfctl (golang)' * fix merge conflict * cli option --project is an init flag * fix to write out project to app.yaml * fix for nil project check * include fix for kubeflow#2367 * added updateDM, createSecrets to Apply * fixes to macros * merge changes from upstream master * remove old files, update README.md * fix for init app-name where app-name is not a path * fix for gcp apply * code to create a Gcp Secret, doesn't do correct auth right now * snapshot * update on downloadK8sManifests, gcpInitProject, added TODO's * additional work on gcpInitProject * gcpInitProject now works but requires GOOGLE_APPLICATION_CREDENTIALS env var * initial pass on updateDeployment * update README.md to described static vs dynamic platforms * updates to Gcp.updateDM, added GOOGLE_APPLICATION_CREDENTIALS to the Makefile tests * minor changes on init, generate usage * snapshot * additional global resources identified * do not delete scalingpolicies * change default platform to ksonnet * default --version to master until 0.5.0 * remove verbose from spark-operator apply * address comments from Jeremy * address comments from Jeremy * fixes kubeflow#2537, refer to no platform as 'none' * add general test for kfctl in Makefile that also tests the plugin capability * remove kftcl config since we now have bootstrap config, fix for DefaultPlatform="none" * change test of platform none to create directory none, updated README * remove reference to docker-for-desktop * update README.md, remove --debug flag (not used) * fixes 'kfctl (golang) Simplify the child/parent relationships in platforms' * fix backendconfig name (kubeflow#2542) * fix backendconfig name * fix test * pin to the latest verified tf-operator commit in order to enable changes in tf-operator HEAD whcih likely break kubeflow checkout tests * fix (kubeflow#2506) * Added unit tests for GetUpdatedPolicy at gcpUtils.go - bootstrap/app (kubeflow#2516) * Added tests for 'GetUpdatedPolicy' - bootstrap/app * Fix typo - gcpUtils_test.go * Added a windows equivalent script for the makefile for central-dashboard (kubeflow#2518) * update katib component (kubeflow#2553) * Refactor for Express + Webpack build stack. (kubeflow#2572) * Refactor for Express + Webpack build stack. - Add webpack to process front-end code in public/ - Add TS and Express for server backend - Update Dockerfile to run the server as Node. - Fix issue with external links. * Updates based on feedback * address review comments * move tests under test directory * Add ESLint to enforce Google JS style in public/ (kubeflow#2579) * Add ESLint to enforce Google JS style in public/ * Switch to 4 space tabs * Updating python package imports related to tf-operator (kubeflow#2581) * updated tf-operator imports * fixed a typo * fixed a typo * Profiles e2e test (kubeflow#2404) * profiles e2e test * fix * review comment * fix * fix * fix * fix * add retry * fix * Update the jupyter-web-app Image (kubeflow#2589) Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * Golang profile controller (kubeflow#2533) * init * create api * wip * fix * fix * fix * fix test * address review * fix test * make it cluster scope * fix test * fix test * fix * turnoff jupyter images authentication (kubeflow#2591) * Updated Jupyter image paths for using in notebook controller (kubeflow#2552) * updated jupyter image paths for using in notebook conroller * removed 1.4.1 image from the list of options * updated jupyter image tags to point to the latest verified ones * updated jupyter images to allow any origin (kubeflow#2606) * Removing prune for Subresource field in CRD (kubeflow#2598) * Adding backOffLimit field to metric collector spec (kubeflow#2597) * remove global resources by label rather than listing all and looking for the label * mv client to coordinator * Fixed Dashboard v0.0.1 w/ Polymer3 + Webpack (kubeflow#2576) * Multiple issues tackled: - Fixed webpack for windows (components/ is not a valid path in windows) - Spacing and semicolons matched to old-codebase - Added cross-platform support to npm run targets - Added missing dep (babel/polyfill) - Dashboard build version is now corrected and hover will reveal kubeflow vs Dashboard versions - Pug fixed to match syntax for empty-value attributes - Updated webpack for readability * Added babel-polyfill to runtime deps rather than dev deps * [Windows-only] Color coded all make output, Tag check added, failures now have messages, also dirty git output now has a warning during build * Updated new dashboard reference :v20190227-v0.4.0-rc.1-176-g738de035 * Fixed Multiple changes: - Server port fixed to 8082 which is what is needed for GKE deployment - Refactored some code * Final working state for new image * TS Changes * Build updated to match latest :v20190301-v0.4.0-rc.1-183-g07eecd2f * Migrated dev dependency to correct location * Uncommented linter, fixed PR comments from @prodonjs * updated jupyter images based on postsubmit results of kubeflow@97b94c0 (kubeflow#2611) * Adding additional printer columns to display status (kubeflow#2609) * Adding additional printer columns to display status * Fixing tests * Semi-working kfctl go binary (kubeflow#2587) * Add flag --skip-init-gcp-project * fix gcpInitProject * update error msg * add deployment creation logic * fix bugs on generateDMData * fix bugs * add default config to ipName and hostName * fix bugs on app.yaml * add Fingerprint to update deployment * make network and gcfs as DM optional * add todos * add iam policy handlers * finish patch iam policy * adding poll op to dm api calls * add gke api version * temp * change mysqlPd/nfsPd names * remove * temp * add config types * add basic auth flag * move config to gcp * link use basic auth flag to generate * use basic auth to determine config path * change to gabrielwen repo for now * change config on the fly * change repo path * create new Genereate method * add required packages * implement NewGenerate * clean up default config and add on-the-fly configs * move config handling to ksonnet.go * add ks param set * add application as component * fix typo * add simple TargetConfiguration factory * add fixed backof * temp * fix from merge * make namespace in gke * bind user as default-admin in gke * finish createSecrets * write oauth secret * uncomment ks apply * add ks show * add ks apply logic to k8sutils * uncomment deployment * build rest.Config from remote * impersonate as admin for rbac * use remote config as REST client config * update default.yaml path * complete apply logic * add retry * add ignore * merge * remove temp comment * use backoff in gcp * remove progress as it is not updating * use backoff * use backoff * use default zone * fix zone config * add doc * add doc * update Makefile * fix flag doc * fix * doc * doc * add doc * sort packages and component names * shell out to gcloud and kubectl for now * remove some configs * fix * remove GkeApiVersion * add todo * add notebook-controller back * change names * updates * add field InitRequired * remove KsInitParams * migrate * Add status to notebook (kubeflow#2558) * wip * wip * update test to check status condition * fix * Add prodonjs to OWNERS (kubeflow#2613) * Changed sidebar tab from JupyterHub to Notebooks (kubeflow#2619) * fix (kubeflow#2620) * pf gcb (kubeflow#2603) * Setting the base_url flag of Jupyter images (kubeflow#2627) * set base_url of jupyter * change the env base_url to NB_PREFIX to sync with kubeflow#2620 * fix (kubeflow#2631) * resolve merge conflicts from upstream/master, fix error on master when --platform=none or not specified * store non exist parameter differently (kubeflow#2625) * fix (kubeflow#2632) * update pipeline system images to 0.1.12 release (kubeflow#2637) * updated jupyter image paths to point to the latest ones (kubeflow#2638) * add retry around ks init (kubeflow#2643) * add retry around ks init * update comments * merge errors * Getting started card completed (kubeflow#2651) * Getting Started card content added, and un-hidden. Windows support added in webpack to run dev builds * Getting Started card fully implemented from mocks * Spaced out cards a little more * Got eslint working! And fixed eslint issues in webpack

* wip * wip * update test to check status condition * fix

@prodonjs

…forms' (kubeflow#2547) * revert to prior version * fixes kfctl (golang) rename 'ks' directory and app to ksonnet and ksonnet.go respectively * fixes 'kfctl - Fetch registry automatically' * fixes 'refactor gcp, minikube, docker-for-desktop, ack to be kfctl plugins' * change DefaultDevRepo to point to just the repo not repo/kubeflow * fixes 'refactor gcp, minikube, docker-for-desktop, ack to be kfctl plugins' * plugins for all existing KfApp instances {ksonnet, minikube, foo}. * update golang version * fixes 'docker-for-desktop' * delete meta-controller-cluster-role-binding * update README.md * remove unused var DEBUG * remove bootstrap/cmd/plugins/foo.go * fixes kfctl (golang) rename 'ks' directory and app to ksonnet and ksonnet.go respectively * fixes 'add the gcp platform to kfctl (golang)' * fix merge conflict * cli option --project is an init flag * fix to write out project to app.yaml * fix for nil project check * include fix for kubeflow#2367 * added updateDM, createSecrets to Apply * fixes to macros * merge changes from upstream master * remove old files, update README.md * fix for init app-name where app-name is not a path * fix for gcp apply * code to create a Gcp Secret, doesn't do correct auth right now * snapshot * update on downloadK8sManifests, gcpInitProject, added TODO's * additional work on gcpInitProject * gcpInitProject now works but requires GOOGLE_APPLICATION_CREDENTIALS env var * initial pass on updateDeployment * update README.md to described static vs dynamic platforms * updates to Gcp.updateDM, added GOOGLE_APPLICATION_CREDENTIALS to the Makefile tests * minor changes on init, generate usage * snapshot * additional global resources identified * do not delete scalingpolicies * change default platform to ksonnet * default --version to master until 0.5.0 * remove verbose from spark-operator apply * address comments from Jeremy * address comments from Jeremy * fixes kubeflow#2537, refer to no platform as 'none' * add general test for kfctl in Makefile that also tests the plugin capability * remove kftcl config since we now have bootstrap config, fix for DefaultPlatform="none" * change test of platform none to create directory none, updated README * remove reference to docker-for-desktop * update README.md, remove --debug flag (not used) * fixes 'kfctl (golang) Simplify the child/parent relationships in platforms' * fix backendconfig name (kubeflow#2542) * fix backendconfig name * fix test * pin to the latest verified tf-operator commit in order to enable changes in tf-operator HEAD whcih likely break kubeflow checkout tests * fix (kubeflow#2506) * Added unit tests for GetUpdatedPolicy at gcpUtils.go - bootstrap/app (kubeflow#2516) * Added tests for 'GetUpdatedPolicy' - bootstrap/app * Fix typo - gcpUtils_test.go * Added a windows equivalent script for the makefile for central-dashboard (kubeflow#2518) * update katib component (kubeflow#2553) * Refactor for Express + Webpack build stack. (kubeflow#2572) * Refactor for Express + Webpack build stack. - Add webpack to process front-end code in public/ - Add TS and Express for server backend - Update Dockerfile to run the server as Node. - Fix issue with external links. * Updates based on feedback * address review comments * move tests under test directory * Add ESLint to enforce Google JS style in public/ (kubeflow#2579) * Add ESLint to enforce Google JS style in public/ * Switch to 4 space tabs * Updating python package imports related to tf-operator (kubeflow#2581) * updated tf-operator imports * fixed a typo * fixed a typo * Profiles e2e test (kubeflow#2404) * profiles e2e test * fix * review comment * fix * fix * fix * fix * add retry * fix * Update the jupyter-web-app Image (kubeflow#2589) Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * Golang profile controller (kubeflow#2533) * init * create api * wip * fix * fix * fix * fix test * address review * fix test * make it cluster scope * fix test * fix test * fix * turnoff jupyter images authentication (kubeflow#2591) * Updated Jupyter image paths for using in notebook controller (kubeflow#2552) * updated jupyter image paths for using in notebook conroller * removed 1.4.1 image from the list of options * updated jupyter image tags to point to the latest verified ones * updated jupyter images to allow any origin (kubeflow#2606) * Removing prune for Subresource field in CRD (kubeflow#2598) * Adding backOffLimit field to metric collector spec (kubeflow#2597) * remove global resources by label rather than listing all and looking for the label * mv client to coordinator * Fixed Dashboard v0.0.1 w/ Polymer3 + Webpack (kubeflow#2576) * Multiple issues tackled: - Fixed webpack for windows (components/ is not a valid path in windows) - Spacing and semicolons matched to old-codebase - Added cross-platform support to npm run targets - Added missing dep (babel/polyfill) - Dashboard build version is now corrected and hover will reveal kubeflow vs Dashboard versions - Pug fixed to match syntax for empty-value attributes - Updated webpack for readability * Added babel-polyfill to runtime deps rather than dev deps * [Windows-only] Color coded all make output, Tag check added, failures now have messages, also dirty git output now has a warning during build * Updated new dashboard reference :v20190227-v0.4.0-rc.1-176-g738de035 * Fixed Multiple changes: - Server port fixed to 8082 which is what is needed for GKE deployment - Refactored some code * Final working state for new image * TS Changes * Build updated to match latest :v20190301-v0.4.0-rc.1-183-g07eecd2f * Migrated dev dependency to correct location * Uncommented linter, fixed PR comments from @prodonjs * updated jupyter images based on postsubmit results of kubeflow@e896cd3 (kubeflow#2611) * Adding additional printer columns to display status (kubeflow#2609) * Adding additional printer columns to display status * Fixing tests * Semi-working kfctl go binary (kubeflow#2587) * Add flag --skip-init-gcp-project * fix gcpInitProject * update error msg * add deployment creation logic * fix bugs on generateDMData * fix bugs * add default config to ipName and hostName * fix bugs on app.yaml * add Fingerprint to update deployment * make network and gcfs as DM optional * add todos * add iam policy handlers * finish patch iam policy * adding poll op to dm api calls * add gke api version * temp * change mysqlPd/nfsPd names * remove * temp * add config types * add basic auth flag * move config to gcp * link use basic auth flag to generate * use basic auth to determine config path * change to gabrielwen repo for now * change config on the fly * change repo path * create new Genereate method * add required packages * implement NewGenerate * clean up default config and add on-the-fly configs * move config handling to ksonnet.go * add ks param set * add application as component * fix typo * add simple TargetConfiguration factory * add fixed backof * temp * fix from merge * make namespace in gke * bind user as default-admin in gke * finish createSecrets * write oauth secret * uncomment ks apply * add ks show * add ks apply logic to k8sutils * uncomment deployment * build rest.Config from remote * impersonate as admin for rbac * use remote config as REST client config * update default.yaml path * complete apply logic * add retry * add ignore * merge * remove temp comment * use backoff in gcp * remove progress as it is not updating * use backoff * use backoff * use default zone * fix zone config * add doc * add doc * update Makefile * fix flag doc * fix * doc * doc * add doc * sort packages and component names * shell out to gcloud and kubectl for now * remove some configs * fix * remove GkeApiVersion * add todo * add notebook-controller back * change names * updates * add field InitRequired * remove KsInitParams * migrate * Add status to notebook (kubeflow#2558) * wip * wip * update test to check status condition * fix * Add prodonjs to OWNERS (kubeflow#2613) * Changed sidebar tab from JupyterHub to Notebooks (kubeflow#2619) * fix (kubeflow#2620) * pf gcb (kubeflow#2603) * Setting the base_url flag of Jupyter images (kubeflow#2627) * set base_url of jupyter * change the env base_url to NB_PREFIX to sync with kubeflow#2620 * fix (kubeflow#2631) * resolve merge conflicts from upstream/master, fix error on master when --platform=none or not specified * store non exist parameter differently (kubeflow#2625) * fix (kubeflow#2632) * update pipeline system images to 0.1.12 release (kubeflow#2637) * updated jupyter image paths to point to the latest ones (kubeflow#2638) * add retry around ks init (kubeflow#2643) * add retry around ks init * update comments * merge errors * Getting started card completed (kubeflow#2651) * Getting Started card content added, and un-hidden. Windows support added in webpack to run dev builds * Getting Started card fully implemented from mocks * Spaced out cards a little more * Got eslint working! And fixed eslint issues in webpack

* wip * wip * update test to check status condition * fix

@prodonjs

…forms' (kubeflow#2547) * revert to prior version * fixes kfctl (golang) rename 'ks' directory and app to ksonnet and ksonnet.go respectively * fixes 'kfctl - Fetch registry automatically' * fixes 'refactor gcp, minikube, docker-for-desktop, ack to be kfctl plugins' * change DefaultDevRepo to point to just the repo not repo/kubeflow * fixes 'refactor gcp, minikube, docker-for-desktop, ack to be kfctl plugins' * plugins for all existing KfApp instances {ksonnet, minikube, foo}. * update golang version * fixes 'docker-for-desktop' * delete meta-controller-cluster-role-binding * update README.md * remove unused var DEBUG * remove bootstrap/cmd/plugins/foo.go * fixes kfctl (golang) rename 'ks' directory and app to ksonnet and ksonnet.go respectively * fixes 'add the gcp platform to kfctl (golang)' * fix merge conflict * cli option --project is an init flag * fix to write out project to app.yaml * fix for nil project check * include fix for kubeflow#2367 * added updateDM, createSecrets to Apply * fixes to macros * merge changes from upstream master * remove old files, update README.md * fix for init app-name where app-name is not a path * fix for gcp apply * code to create a Gcp Secret, doesn't do correct auth right now * snapshot * update on downloadK8sManifests, gcpInitProject, added TODO's * additional work on gcpInitProject * gcpInitProject now works but requires GOOGLE_APPLICATION_CREDENTIALS env var * initial pass on updateDeployment * update README.md to described static vs dynamic platforms * updates to Gcp.updateDM, added GOOGLE_APPLICATION_CREDENTIALS to the Makefile tests * minor changes on init, generate usage * snapshot * additional global resources identified * do not delete scalingpolicies * change default platform to ksonnet * default --version to master until 0.5.0 * remove verbose from spark-operator apply * address comments from Jeremy * address comments from Jeremy * fixes kubeflow#2537, refer to no platform as 'none' * add general test for kfctl in Makefile that also tests the plugin capability * remove kftcl config since we now have bootstrap config, fix for DefaultPlatform="none" * change test of platform none to create directory none, updated README * remove reference to docker-for-desktop * update README.md, remove --debug flag (not used) * fixes 'kfctl (golang) Simplify the child/parent relationships in platforms' * fix backendconfig name (kubeflow#2542) * fix backendconfig name * fix test * pin to the latest verified tf-operator commit in order to enable changes in tf-operator HEAD whcih likely break kubeflow checkout tests * fix (kubeflow#2506) * Added unit tests for GetUpdatedPolicy at gcpUtils.go - bootstrap/app (kubeflow#2516) * Added tests for 'GetUpdatedPolicy' - bootstrap/app * Fix typo - gcpUtils_test.go * Added a windows equivalent script for the makefile for central-dashboard (kubeflow#2518) * update katib component (kubeflow#2553) * Refactor for Express + Webpack build stack. (kubeflow#2572) * Refactor for Express + Webpack build stack. - Add webpack to process front-end code in public/ - Add TS and Express for server backend - Update Dockerfile to run the server as Node. - Fix issue with external links. * Updates based on feedback * address review comments * move tests under test directory * Add ESLint to enforce Google JS style in public/ (kubeflow#2579) * Add ESLint to enforce Google JS style in public/ * Switch to 4 space tabs * Updating python package imports related to tf-operator (kubeflow#2581) * updated tf-operator imports * fixed a typo * fixed a typo * Profiles e2e test (kubeflow#2404) * profiles e2e test * fix * review comment * fix * fix * fix * fix * add retry * fix * Update the jupyter-web-app Image (kubeflow#2589) Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * Golang profile controller (kubeflow#2533) * init * create api * wip * fix * fix * fix * fix test * address review * fix test * make it cluster scope * fix test * fix test * fix * turnoff jupyter images authentication (kubeflow#2591) * Updated Jupyter image paths for using in notebook controller (kubeflow#2552) * updated jupyter image paths for using in notebook conroller * removed 1.4.1 image from the list of options * updated jupyter image tags to point to the latest verified ones * updated jupyter images to allow any origin (kubeflow#2606) * Removing prune for Subresource field in CRD (kubeflow#2598) * Adding backOffLimit field to metric collector spec (kubeflow#2597) * remove global resources by label rather than listing all and looking for the label * mv client to coordinator * Fixed Dashboard v0.0.1 w/ Polymer3 + Webpack (kubeflow#2576) * Multiple issues tackled: - Fixed webpack for windows (components/ is not a valid path in windows) - Spacing and semicolons matched to old-codebase - Added cross-platform support to npm run targets - Added missing dep (babel/polyfill) - Dashboard build version is now corrected and hover will reveal kubeflow vs Dashboard versions - Pug fixed to match syntax for empty-value attributes - Updated webpack for readability * Added babel-polyfill to runtime deps rather than dev deps * [Windows-only] Color coded all make output, Tag check added, failures now have messages, also dirty git output now has a warning during build * Updated new dashboard reference :v20190227-v0.4.0-rc.1-176-g738de035 * Fixed Multiple changes: - Server port fixed to 8082 which is what is needed for GKE deployment - Refactored some code * Final working state for new image * TS Changes * Build updated to match latest :v20190301-v0.4.0-rc.1-183-g07eecd2f * Migrated dev dependency to correct location * Uncommented linter, fixed PR comments from @prodonjs * updated jupyter images based on postsubmit results of kubeflow@598dd06 (kubeflow#2611) * Adding additional printer columns to display status (kubeflow#2609) * Adding additional printer columns to display status * Fixing tests * Semi-working kfctl go binary (kubeflow#2587) * Add flag --skip-init-gcp-project * fix gcpInitProject * update error msg * add deployment creation logic * fix bugs on generateDMData * fix bugs * add default config to ipName and hostName * fix bugs on app.yaml * add Fingerprint to update deployment * make network and gcfs as DM optional * add todos * add iam policy handlers * finish patch iam policy * adding poll op to dm api calls * add gke api version * temp * change mysqlPd/nfsPd names * remove * temp * add config types * add basic auth flag * move config to gcp * link use basic auth flag to generate * use basic auth to determine config path * change to gabrielwen repo for now * change config on the fly * change repo path * create new Genereate method * add required packages * implement NewGenerate * clean up default config and add on-the-fly configs * move config handling to ksonnet.go * add ks param set * add application as component * fix typo * add simple TargetConfiguration factory * add fixed backof * temp * fix from merge * make namespace in gke * bind user as default-admin in gke * finish createSecrets * write oauth secret * uncomment ks apply * add ks show * add ks apply logic to k8sutils * uncomment deployment * build rest.Config from remote * impersonate as admin for rbac * use remote config as REST client config * update default.yaml path * complete apply logic * add retry * add ignore * merge * remove temp comment * use backoff in gcp * remove progress as it is not updating * use backoff * use backoff * use default zone * fix zone config * add doc * add doc * update Makefile * fix flag doc * fix * doc * doc * add doc * sort packages and component names * shell out to gcloud and kubectl for now * remove some configs * fix * remove GkeApiVersion * add todo * add notebook-controller back * change names * updates * add field InitRequired * remove KsInitParams * migrate * Add status to notebook (kubeflow#2558) * wip * wip * update test to check status condition * fix * Add prodonjs to OWNERS (kubeflow#2613) * Changed sidebar tab from JupyterHub to Notebooks (kubeflow#2619) * fix (kubeflow#2620) * pf gcb (kubeflow#2603) * Setting the base_url flag of Jupyter images (kubeflow#2627) * set base_url of jupyter * change the env base_url to NB_PREFIX to sync with kubeflow#2620 * fix (kubeflow#2631) * resolve merge conflicts from upstream/master, fix error on master when --platform=none or not specified * store non exist parameter differently (kubeflow#2625) * fix (kubeflow#2632) * update pipeline system images to 0.1.12 release (kubeflow#2637) * updated jupyter image paths to point to the latest ones (kubeflow#2638) * add retry around ks init (kubeflow#2643) * add retry around ks init * update comments * merge errors * Getting started card completed (kubeflow#2651) * Getting Started card content added, and un-hidden. Windows support added in webpack to run dev builds * Getting Started card fully implemented from mocks * Spaced out cards a little more * Got eslint working! And fixed eslint issues in webpack

lluunn added 2 commits February 26, 2019 13:41

wip

d1e2aa9

Merge branch 'master' into nb2

4c719fd

k8s-ci-robot added the do-not-merge/work-in-progress label Feb 26, 2019

googlebot added the cla: yes label Feb 26, 2019

k8s-ci-robot added the size/L label Feb 26, 2019

k8s-ci-robot requested review from ellistarn and kunmingg February 26, 2019 21:42

lluunn added 4 commits February 26, 2019 17:28

wip

3c19a45

update test to check status condition

2f873ff

Merge branch 'master' into nb2

3b973ec

fix

87856bc

lluunn changed the title ~~WIP~~ Add status to notebook Feb 28, 2019

k8s-ci-robot removed the do-not-merge/work-in-progress label Feb 28, 2019

Merge branch 'master' into nb2

1300088

lluunn mentioned this pull request Feb 28, 2019

jupyter web app should provide status of notebook #2588

Closed

k8s-ci-robot added the do-not-merge/work-in-progress label Mar 1, 2019

lluunn marked this pull request as ready for review March 1, 2019 01:48

k8s-ci-robot assigned jlewi, kkasravi and richardsliu Mar 1, 2019

lluunn removed the do-not-merge/work-in-progress label Mar 1, 2019

jlewi removed their assignment Mar 1, 2019

jlewi removed the request for review from ellistarn March 1, 2019 16:30

richardsliu reviewed Mar 4, 2019

View reviewed changes

k8s-ci-robot added the lgtm label Mar 4, 2019

k8s-ci-robot added the approved label Mar 4, 2019

kunmingg reviewed Mar 4, 2019

View reviewed changes

k8s-ci-robot merged commit e1d7ef8 into kubeflow:master Mar 4, 2019

kkasravi pushed a commit to kkasravi/kubeflow that referenced this pull request Mar 8, 2019

Add status to notebook (kubeflow#2558)

50c83c1

* wip * wip * update test to check status condition * fix

kkasravi pushed a commit to kkasravi/kubeflow that referenced this pull request Mar 8, 2019

Add status to notebook (kubeflow#2558)

74d1615

* wip * wip * update test to check status condition * fix

jlewi mentioned this pull request Mar 17, 2019

Jupyter resource should indicate when notebook is running #2723

Closed

saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021

Add status to notebook (kubeflow#2558)

afd0c0c

* wip * wip * update test to check status condition * fix

saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 12, 2021

Add status to notebook (kubeflow#2558)

a233e41

* wip * wip * update test to check status condition * fix

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add status to notebook #2558

Add status to notebook #2558

lluunn commented Feb 26, 2019 •

edited

lluunn commented Feb 28, 2019

lluunn commented Mar 1, 2019

lluunn commented Mar 1, 2019

jlewi commented Mar 1, 2019

richardsliu Mar 4, 2019

lluunn Mar 4, 2019

richardsliu Mar 4, 2019

lluunn Mar 4, 2019

richardsliu commented Mar 4, 2019

k8s-ci-robot commented Mar 4, 2019

lluunn commented Mar 4, 2019

lluunn commented Mar 4, 2019

kunmingg Mar 4, 2019

lluunn Mar 4, 2019

kunmingg Mar 4, 2019

lluunn Mar 4, 2019

Add status to notebook #2558

Add status to notebook #2558

Conversation

lluunn commented Feb 26, 2019 • edited

lluunn commented Feb 28, 2019

lluunn commented Mar 1, 2019

lluunn commented Mar 1, 2019

jlewi commented Mar 1, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

richardsliu commented Mar 4, 2019

k8s-ci-robot commented Mar 4, 2019

lluunn commented Mar 4, 2019

lluunn commented Mar 4, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lluunn commented Feb 26, 2019 •

edited