Getting started card completed #2651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/M
priority/p0
area/front-end
area/centraldashboard
|
/test kubeflow-presubmit |
1 similar comment
|
/test kubeflow-presubmit |
prodonjs
suggested changes
Mar 7, 2019
There was a problem hiding this comment.
See comments. The linter fails due to the line length for the descriptions. We may want to create a separate JS module for texts anyways in case we need to prepare for I18n.
Also, I can't seem to figure out why you are having issues with the eslint settings in Windows. I did a checkout and build on a fresh Windows install and things seemed to work as expected.
prodonjs
reviewed
Mar 7, 2019
| { | ||
| text: 'Getting started with Kubeflow', | ||
| desc: 'Quickly get running with your ML workflow on an existing Kubernetes installation', | ||
| link: 'https://www.kubeflow.org/docs/started/getting-started/', |
There was a problem hiding this comment.
It seems a bit odd that these links open externally versus using the iframe view which would be activated if the user clicked Kubeflow Docs from the sidenav. My open PR #2614 will refactor this section and add the router, but I'm curious if you think we should make these links appear in the iframe as well.
There was a problem hiding this comment.
Your logic makes perfect sense, and that was my initial goal. However, that is no longer the desired behavior as mentioned in #2546.
I am waiting for your PR to then refactor all links to hrefs
|
Correct me if I am wrong, but I18n isn't on the Agenda for landing page right? @ajayalfred |
|
/test kubeflow-presubmit |
|
I still don't understand why your specific environment is not letting us use the standard method of putting the configuration file in the directory where it will be applied. I don't want to hold things up though so we'll have to investigate that later. /lgtm |
|
/approved |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: prodonjs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
prodonjs
added a commit
to prodonjs/kubeflow
that referenced
this pull request
Mar 8, 2019
kkasravi
pushed a commit
to kkasravi/kubeflow
that referenced
this pull request
Mar 8, 2019
* Getting Started card content added, and un-hidden. Windows support added in webpack to run dev builds * Getting Started card fully implemented from mocks * Spaced out cards a little more * Got eslint working! And fixed eslint issues in webpack
k8s-ci-robot
pushed a commit
that referenced
this pull request
Mar 8, 2019
…forms' (#2547) * revert to prior version * fixes kfctl (golang) rename 'ks' directory and app to ksonnet and ksonnet.go respectively * fixes 'kfctl - Fetch registry automatically' * fixes 'refactor gcp, minikube, docker-for-desktop, ack to be kfctl plugins' * change DefaultDevRepo to point to just the repo not repo/kubeflow * fixes 'refactor gcp, minikube, docker-for-desktop, ack to be kfctl plugins' * plugins for all existing KfApp instances {ksonnet, minikube, foo}. * update golang version * fixes 'docker-for-desktop' * delete meta-controller-cluster-role-binding * update README.md * remove unused var DEBUG * remove bootstrap/cmd/plugins/foo.go * fixes kfctl (golang) rename 'ks' directory and app to ksonnet and ksonnet.go respectively * fixes 'add the gcp platform to kfctl (golang)' * fix merge conflict * cli option --project is an init flag * fix to write out project to app.yaml * fix for nil project check * include fix for #2367 * added updateDM, createSecrets to Apply * fixes to macros * merge changes from upstream master * remove old files, update README.md * fix for init app-name where app-name is not a path * fix for gcp apply * code to create a Gcp Secret, doesn't do correct auth right now * snapshot * update on downloadK8sManifests, gcpInitProject, added TODO's * additional work on gcpInitProject * gcpInitProject now works but requires GOOGLE_APPLICATION_CREDENTIALS env var * initial pass on updateDeployment * update README.md to described static vs dynamic platforms * updates to Gcp.updateDM, added GOOGLE_APPLICATION_CREDENTIALS to the Makefile tests * minor changes on init, generate usage * snapshot * additional global resources identified * do not delete scalingpolicies * change default platform to ksonnet * default --version to master until 0.5.0 * remove verbose from spark-operator apply * address comments from Jeremy * address comments from Jeremy * fixes #2537, refer to no platform as 'none' * add general test for kfctl in Makefile that also tests the plugin capability * remove kftcl config since we now have bootstrap config, fix for DefaultPlatform="none" * change test of platform none to create directory none, updated README * remove reference to docker-for-desktop * update README.md, remove --debug flag (not used) * fixes 'kfctl (golang) Simplify the child/parent relationships in platforms' * fix backendconfig name (#2542) * fix backendconfig name * fix test * pin to the latest verified tf-operator commit in order to enable changes in tf-operator HEAD whcih likely break kubeflow checkout tests * fix (#2506) * Added unit tests for GetUpdatedPolicy at gcpUtils.go - bootstrap/app (#2516) * Added tests for 'GetUpdatedPolicy' - bootstrap/app * Fix typo - gcpUtils_test.go * Added a windows equivalent script for the makefile for central-dashboard (#2518) * update katib component (#2553) * Refactor for Express + Webpack build stack. (#2572) * Refactor for Express + Webpack build stack. - Add webpack to process front-end code in public/ - Add TS and Express for server backend - Update Dockerfile to run the server as Node. - Fix issue with external links. * Updates based on feedback * address review comments * move tests under test directory * Add ESLint to enforce Google JS style in public/ (#2579) * Add ESLint to enforce Google JS style in public/ * Switch to 4 space tabs * Updating python package imports related to tf-operator (#2581) * updated tf-operator imports * fixed a typo * fixed a typo * Profiles e2e test (#2404) * profiles e2e test * fix * review comment * fix * fix * fix * fix * add retry * fix * Update the jupyter-web-app Image (#2589) Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * Golang profile controller (#2533) * init * create api * wip * fix * fix * fix * fix test * address review * fix test * make it cluster scope * fix test * fix test * fix * turnoff jupyter images authentication (#2591) * Updated Jupyter image paths for using in notebook controller (#2552) * updated jupyter image paths for using in notebook conroller * removed 1.4.1 image from the list of options * updated jupyter image tags to point to the latest verified ones * updated jupyter images to allow any origin (#2606) * Removing prune for Subresource field in CRD (#2598) * Adding backOffLimit field to metric collector spec (#2597) * remove global resources by label rather than listing all and looking for the label * mv client to coordinator * Fixed Dashboard v0.0.1 w/ Polymer3 + Webpack (#2576) * Multiple issues tackled: - Fixed webpack for windows (components/ is not a valid path in windows) - Spacing and semicolons matched to old-codebase - Added cross-platform support to npm run targets - Added missing dep (babel/polyfill) - Dashboard build version is now corrected and hover will reveal kubeflow vs Dashboard versions - Pug fixed to match syntax for empty-value attributes - Updated webpack for readability * Added babel-polyfill to runtime deps rather than dev deps * [Windows-only] Color coded all make output, Tag check added, failures now have messages, also dirty git output now has a warning during build * Updated new dashboard reference :v20190227-v0.4.0-rc.1-176-g738de035 * Fixed Multiple changes: - Server port fixed to 8082 which is what is needed for GKE deployment - Refactored some code * Final working state for new image * TS Changes * Build updated to match latest :v20190301-v0.4.0-rc.1-183-g07eecd2f * Migrated dev dependency to correct location * Uncommented linter, fixed PR comments from @prodonjs * updated jupyter images based on postsubmit results of 97b94c0 (#2611) * Adding additional printer columns to display status (#2609) * Adding additional printer columns to display status * Fixing tests * Semi-working kfctl go binary (#2587) * Add flag --skip-init-gcp-project * fix gcpInitProject * update error msg * add deployment creation logic * fix bugs on generateDMData * fix bugs * add default config to ipName and hostName * fix bugs on app.yaml * add Fingerprint to update deployment * make network and gcfs as DM optional * add todos * add iam policy handlers * finish patch iam policy * adding poll op to dm api calls * add gke api version * temp * change mysqlPd/nfsPd names * remove * temp * add config types * add basic auth flag * move config to gcp * link use basic auth flag to generate * use basic auth to determine config path * change to gabrielwen repo for now * change config on the fly * change repo path * create new Genereate method * add required packages * implement NewGenerate * clean up default config and add on-the-fly configs * move config handling to ksonnet.go * add ks param set * add application as component * fix typo * add simple TargetConfiguration factory * add fixed backof * temp * fix from merge * make namespace in gke * bind user as default-admin in gke * finish createSecrets * write oauth secret * uncomment ks apply * add ks show * add ks apply logic to k8sutils * uncomment deployment * build rest.Config from remote * impersonate as admin for rbac * use remote config as REST client config * update default.yaml path * complete apply logic * add retry * add ignore * merge * remove temp comment * use backoff in gcp * remove progress as it is not updating * use backoff * use backoff * use default zone * fix zone config * add doc * add doc * update Makefile * fix flag doc * fix * doc * doc * add doc * sort packages and component names * shell out to gcloud and kubectl for now * remove some configs * fix * remove GkeApiVersion * add todo * add notebook-controller back * change names * updates * add field InitRequired * remove KsInitParams * migrate * Add status to notebook (#2558) * wip * wip * update test to check status condition * fix * Add prodonjs to OWNERS (#2613) * Changed sidebar tab from JupyterHub to Notebooks (#2619) * fix (#2620) * pf gcb (#2603) * Setting the base_url flag of Jupyter images (#2627) * set base_url of jupyter * change the env base_url to NB_PREFIX to sync with #2620 * fix (#2631) * resolve merge conflicts from upstream/master, fix error on master when --platform=none or not specified * store non exist parameter differently (#2625) * fix (#2632) * update pipeline system images to 0.1.12 release (#2637) * updated jupyter image paths to point to the latest ones (#2638) * add retry around ks init (#2643) * add retry around ks init * update comments * merge errors * Getting started card completed (#2651) * Getting Started card content added, and un-hidden. Windows support added in webpack to run dev builds * Getting Started card fully implemented from mocks * Spaced out cards a little more * Got eslint working! And fixed eslint issues in webpack
prodonjs
added a commit
to prodonjs/kubeflow
that referenced
this pull request
Mar 8, 2019
k8s-ci-robot
pushed a commit
that referenced
this pull request
Mar 8, 2019
* Separate front-end components and add mock activities service. - Adds deep-link routing behavior for all front-end pages. Iframed pages reflect a URL to the browser that makes them linkable but hides the internal page. - Seperates the front-end into subcomponents, including an activities view. - Fix iframe view behavior to have it cover the space voided by the layout header. - Adds /api/activities endpoint to the Express server for activities to eventually be replaced with real data. - Sets the _devMode flag to true based on the webpack build env. * Address PR comments * Merge changes from PR #2651
kkasravi
pushed a commit
to kkasravi/kubeflow
that referenced
this pull request
Mar 8, 2019
…forms' (kubeflow#2547) * revert to prior version * fixes kfctl (golang) rename 'ks' directory and app to ksonnet and ksonnet.go respectively * fixes 'kfctl - Fetch registry automatically' * fixes 'refactor gcp, minikube, docker-for-desktop, ack to be kfctl plugins' * change DefaultDevRepo to point to just the repo not repo/kubeflow * fixes 'refactor gcp, minikube, docker-for-desktop, ack to be kfctl plugins' * plugins for all existing KfApp instances {ksonnet, minikube, foo}. * update golang version * fixes 'docker-for-desktop' * delete meta-controller-cluster-role-binding * update README.md * remove unused var DEBUG * remove bootstrap/cmd/plugins/foo.go * fixes kfctl (golang) rename 'ks' directory and app to ksonnet and ksonnet.go respectively * fixes 'add the gcp platform to kfctl (golang)' * fix merge conflict * cli option --project is an init flag * fix to write out project to app.yaml * fix for nil project check * include fix for kubeflow#2367 * added updateDM, createSecrets to Apply * fixes to macros * merge changes from upstream master * remove old files, update README.md * fix for init app-name where app-name is not a path * fix for gcp apply * code to create a Gcp Secret, doesn't do correct auth right now * snapshot * update on downloadK8sManifests, gcpInitProject, added TODO's * additional work on gcpInitProject * gcpInitProject now works but requires GOOGLE_APPLICATION_CREDENTIALS env var * initial pass on updateDeployment * update README.md to described static vs dynamic platforms * updates to Gcp.updateDM, added GOOGLE_APPLICATION_CREDENTIALS to the Makefile tests * minor changes on init, generate usage * snapshot * additional global resources identified * do not delete scalingpolicies * change default platform to ksonnet * default --version to master until 0.5.0 * remove verbose from spark-operator apply * address comments from Jeremy * address comments from Jeremy * fixes kubeflow#2537, refer to no platform as 'none' * add general test for kfctl in Makefile that also tests the plugin capability * remove kftcl config since we now have bootstrap config, fix for DefaultPlatform="none" * change test of platform none to create directory none, updated README * remove reference to docker-for-desktop * update README.md, remove --debug flag (not used) * fixes 'kfctl (golang) Simplify the child/parent relationships in platforms' * fix backendconfig name (kubeflow#2542) * fix backendconfig name * fix test * pin to the latest verified tf-operator commit in order to enable changes in tf-operator HEAD whcih likely break kubeflow checkout tests * fix (kubeflow#2506) * Added unit tests for GetUpdatedPolicy at gcpUtils.go - bootstrap/app (kubeflow#2516) * Added tests for 'GetUpdatedPolicy' - bootstrap/app * Fix typo - gcpUtils_test.go * Added a windows equivalent script for the makefile for central-dashboard (kubeflow#2518) * update katib component (kubeflow#2553) * Refactor for Express + Webpack build stack. (kubeflow#2572) * Refactor for Express + Webpack build stack. - Add webpack to process front-end code in public/ - Add TS and Express for server backend - Update Dockerfile to run the server as Node. - Fix issue with external links. * Updates based on feedback * address review comments * move tests under test directory * Add ESLint to enforce Google JS style in public/ (kubeflow#2579) * Add ESLint to enforce Google JS style in public/ * Switch to 4 space tabs * Updating python package imports related to tf-operator (kubeflow#2581) * updated tf-operator imports * fixed a typo * fixed a typo * Profiles e2e test (kubeflow#2404) * profiles e2e test * fix * review comment * fix * fix * fix * fix * add retry * fix * Update the jupyter-web-app Image (kubeflow#2589) Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * Golang profile controller (kubeflow#2533) * init * create api * wip * fix * fix * fix * fix test * address review * fix test * make it cluster scope * fix test * fix test * fix * turnoff jupyter images authentication (kubeflow#2591) * Updated Jupyter image paths for using in notebook controller (kubeflow#2552) * updated jupyter image paths for using in notebook conroller * removed 1.4.1 image from the list of options * updated jupyter image tags to point to the latest verified ones * updated jupyter images to allow any origin (kubeflow#2606) * Removing prune for Subresource field in CRD (kubeflow#2598) * Adding backOffLimit field to metric collector spec (kubeflow#2597) * remove global resources by label rather than listing all and looking for the label * mv client to coordinator * Fixed Dashboard v0.0.1 w/ Polymer3 + Webpack (kubeflow#2576) * Multiple issues tackled: - Fixed webpack for windows (components/ is not a valid path in windows) - Spacing and semicolons matched to old-codebase - Added cross-platform support to npm run targets - Added missing dep (babel/polyfill) - Dashboard build version is now corrected and hover will reveal kubeflow vs Dashboard versions - Pug fixed to match syntax for empty-value attributes - Updated webpack for readability * Added babel-polyfill to runtime deps rather than dev deps * [Windows-only] Color coded all make output, Tag check added, failures now have messages, also dirty git output now has a warning during build * Updated new dashboard reference :v20190227-v0.4.0-rc.1-176-g738de035 * Fixed Multiple changes: - Server port fixed to 8082 which is what is needed for GKE deployment - Refactored some code * Final working state for new image * TS Changes * Build updated to match latest :v20190301-v0.4.0-rc.1-183-g07eecd2f * Migrated dev dependency to correct location * Uncommented linter, fixed PR comments from @prodonjs * updated jupyter images based on postsubmit results of kubeflow@97b94c0 (kubeflow#2611) * Adding additional printer columns to display status (kubeflow#2609) * Adding additional printer columns to display status * Fixing tests * Semi-working kfctl go binary (kubeflow#2587) * Add flag --skip-init-gcp-project * fix gcpInitProject * update error msg * add deployment creation logic * fix bugs on generateDMData * fix bugs * add default config to ipName and hostName * fix bugs on app.yaml * add Fingerprint to update deployment * make network and gcfs as DM optional * add todos * add iam policy handlers * finish patch iam policy * adding poll op to dm api calls * add gke api version * temp * change mysqlPd/nfsPd names * remove * temp * add config types * add basic auth flag * move config to gcp * link use basic auth flag to generate * use basic auth to determine config path * change to gabrielwen repo for now * change config on the fly * change repo path * create new Genereate method * add required packages * implement NewGenerate * clean up default config and add on-the-fly configs * move config handling to ksonnet.go * add ks param set * add application as component * fix typo * add simple TargetConfiguration factory * add fixed backof * temp * fix from merge * make namespace in gke * bind user as default-admin in gke * finish createSecrets * write oauth secret * uncomment ks apply * add ks show * add ks apply logic to k8sutils * uncomment deployment * build rest.Config from remote * impersonate as admin for rbac * use remote config as REST client config * update default.yaml path * complete apply logic * add retry * add ignore * merge * remove temp comment * use backoff in gcp * remove progress as it is not updating * use backoff * use backoff * use default zone * fix zone config * add doc * add doc * update Makefile * fix flag doc * fix * doc * doc * add doc * sort packages and component names * shell out to gcloud and kubectl for now * remove some configs * fix * remove GkeApiVersion * add todo * add notebook-controller back * change names * updates * add field InitRequired * remove KsInitParams * migrate * Add status to notebook (kubeflow#2558) * wip * wip * update test to check status condition * fix * Add prodonjs to OWNERS (kubeflow#2613) * Changed sidebar tab from JupyterHub to Notebooks (kubeflow#2619) * fix (kubeflow#2620) * pf gcb (kubeflow#2603) * Setting the base_url flag of Jupyter images (kubeflow#2627) * set base_url of jupyter * change the env base_url to NB_PREFIX to sync with kubeflow#2620 * fix (kubeflow#2631) * resolve merge conflicts from upstream/master, fix error on master when --platform=none or not specified * store non exist parameter differently (kubeflow#2625) * fix (kubeflow#2632) * update pipeline system images to 0.1.12 release (kubeflow#2637) * updated jupyter image paths to point to the latest ones (kubeflow#2638) * add retry around ks init (kubeflow#2643) * add retry around ks init * update comments * merge errors * Getting started card completed (kubeflow#2651) * Getting Started card content added, and un-hidden. Windows support added in webpack to run dev builds * Getting Started card fully implemented from mocks * Spaced out cards a little more * Got eslint working! And fixed eslint issues in webpack
kkasravi
pushed a commit
to kkasravi/kubeflow
that referenced
this pull request
Mar 8, 2019
…low#2626) * Separate front-end components and add mock activities service. - Adds deep-link routing behavior for all front-end pages. Iframed pages reflect a URL to the browser that makes them linkable but hides the internal page. - Seperates the front-end into subcomponents, including an activities view. - Fix iframe view behavior to have it cover the space voided by the layout header. - Adds /api/activities endpoint to the Express server for activities to eventually be replaced with real data. - Sets the _devMode flag to true based on the webpack build env. * Address PR comments * Merge changes from PR kubeflow#2651
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
* Getting Started card content added, and un-hidden. Windows support added in webpack to run dev builds * Getting Started card fully implemented from mocks * Spaced out cards a little more * Got eslint working! And fixed eslint issues in webpack
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
…forms' (kubeflow#2547) * revert to prior version * fixes kfctl (golang) rename 'ks' directory and app to ksonnet and ksonnet.go respectively * fixes 'kfctl - Fetch registry automatically' * fixes 'refactor gcp, minikube, docker-for-desktop, ack to be kfctl plugins' * change DefaultDevRepo to point to just the repo not repo/kubeflow * fixes 'refactor gcp, minikube, docker-for-desktop, ack to be kfctl plugins' * plugins for all existing KfApp instances {ksonnet, minikube, foo}. * update golang version * fixes 'docker-for-desktop' * delete meta-controller-cluster-role-binding * update README.md * remove unused var DEBUG * remove bootstrap/cmd/plugins/foo.go * fixes kfctl (golang) rename 'ks' directory and app to ksonnet and ksonnet.go respectively * fixes 'add the gcp platform to kfctl (golang)' * fix merge conflict * cli option --project is an init flag * fix to write out project to app.yaml * fix for nil project check * include fix for kubeflow#2367 * added updateDM, createSecrets to Apply * fixes to macros * merge changes from upstream master * remove old files, update README.md * fix for init app-name where app-name is not a path * fix for gcp apply * code to create a Gcp Secret, doesn't do correct auth right now * snapshot * update on downloadK8sManifests, gcpInitProject, added TODO's * additional work on gcpInitProject * gcpInitProject now works but requires GOOGLE_APPLICATION_CREDENTIALS env var * initial pass on updateDeployment * update README.md to described static vs dynamic platforms * updates to Gcp.updateDM, added GOOGLE_APPLICATION_CREDENTIALS to the Makefile tests * minor changes on init, generate usage * snapshot * additional global resources identified * do not delete scalingpolicies * change default platform to ksonnet * default --version to master until 0.5.0 * remove verbose from spark-operator apply * address comments from Jeremy * address comments from Jeremy * fixes kubeflow#2537, refer to no platform as 'none' * add general test for kfctl in Makefile that also tests the plugin capability * remove kftcl config since we now have bootstrap config, fix for DefaultPlatform="none" * change test of platform none to create directory none, updated README * remove reference to docker-for-desktop * update README.md, remove --debug flag (not used) * fixes 'kfctl (golang) Simplify the child/parent relationships in platforms' * fix backendconfig name (kubeflow#2542) * fix backendconfig name * fix test * pin to the latest verified tf-operator commit in order to enable changes in tf-operator HEAD whcih likely break kubeflow checkout tests * fix (kubeflow#2506) * Added unit tests for GetUpdatedPolicy at gcpUtils.go - bootstrap/app (kubeflow#2516) * Added tests for 'GetUpdatedPolicy' - bootstrap/app * Fix typo - gcpUtils_test.go * Added a windows equivalent script for the makefile for central-dashboard (kubeflow#2518) * update katib component (kubeflow#2553) * Refactor for Express + Webpack build stack. (kubeflow#2572) * Refactor for Express + Webpack build stack. - Add webpack to process front-end code in public/ - Add TS and Express for server backend - Update Dockerfile to run the server as Node. - Fix issue with external links. * Updates based on feedback * address review comments * move tests under test directory * Add ESLint to enforce Google JS style in public/ (kubeflow#2579) * Add ESLint to enforce Google JS style in public/ * Switch to 4 space tabs * Updating python package imports related to tf-operator (kubeflow#2581) * updated tf-operator imports * fixed a typo * fixed a typo * Profiles e2e test (kubeflow#2404) * profiles e2e test * fix * review comment * fix * fix * fix * fix * add retry * fix * Update the jupyter-web-app Image (kubeflow#2589) Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * Golang profile controller (kubeflow#2533) * init * create api * wip * fix * fix * fix * fix test * address review * fix test * make it cluster scope * fix test * fix test * fix * turnoff jupyter images authentication (kubeflow#2591) * Updated Jupyter image paths for using in notebook controller (kubeflow#2552) * updated jupyter image paths for using in notebook conroller * removed 1.4.1 image from the list of options * updated jupyter image tags to point to the latest verified ones * updated jupyter images to allow any origin (kubeflow#2606) * Removing prune for Subresource field in CRD (kubeflow#2598) * Adding backOffLimit field to metric collector spec (kubeflow#2597) * remove global resources by label rather than listing all and looking for the label * mv client to coordinator * Fixed Dashboard v0.0.1 w/ Polymer3 + Webpack (kubeflow#2576) * Multiple issues tackled: - Fixed webpack for windows (components/ is not a valid path in windows) - Spacing and semicolons matched to old-codebase - Added cross-platform support to npm run targets - Added missing dep (babel/polyfill) - Dashboard build version is now corrected and hover will reveal kubeflow vs Dashboard versions - Pug fixed to match syntax for empty-value attributes - Updated webpack for readability * Added babel-polyfill to runtime deps rather than dev deps * [Windows-only] Color coded all make output, Tag check added, failures now have messages, also dirty git output now has a warning during build * Updated new dashboard reference :v20190227-v0.4.0-rc.1-176-g738de035 * Fixed Multiple changes: - Server port fixed to 8082 which is what is needed for GKE deployment - Refactored some code * Final working state for new image * TS Changes * Build updated to match latest :v20190301-v0.4.0-rc.1-183-g07eecd2f * Migrated dev dependency to correct location * Uncommented linter, fixed PR comments from @prodonjs * updated jupyter images based on postsubmit results of kubeflow@e896cd3 (kubeflow#2611) * Adding additional printer columns to display status (kubeflow#2609) * Adding additional printer columns to display status * Fixing tests * Semi-working kfctl go binary (kubeflow#2587) * Add flag --skip-init-gcp-project * fix gcpInitProject * update error msg * add deployment creation logic * fix bugs on generateDMData * fix bugs * add default config to ipName and hostName * fix bugs on app.yaml * add Fingerprint to update deployment * make network and gcfs as DM optional * add todos * add iam policy handlers * finish patch iam policy * adding poll op to dm api calls * add gke api version * temp * change mysqlPd/nfsPd names * remove * temp * add config types * add basic auth flag * move config to gcp * link use basic auth flag to generate * use basic auth to determine config path * change to gabrielwen repo for now * change config on the fly * change repo path * create new Genereate method * add required packages * implement NewGenerate * clean up default config and add on-the-fly configs * move config handling to ksonnet.go * add ks param set * add application as component * fix typo * add simple TargetConfiguration factory * add fixed backof * temp * fix from merge * make namespace in gke * bind user as default-admin in gke * finish createSecrets * write oauth secret * uncomment ks apply * add ks show * add ks apply logic to k8sutils * uncomment deployment * build rest.Config from remote * impersonate as admin for rbac * use remote config as REST client config * update default.yaml path * complete apply logic * add retry * add ignore * merge * remove temp comment * use backoff in gcp * remove progress as it is not updating * use backoff * use backoff * use default zone * fix zone config * add doc * add doc * update Makefile * fix flag doc * fix * doc * doc * add doc * sort packages and component names * shell out to gcloud and kubectl for now * remove some configs * fix * remove GkeApiVersion * add todo * add notebook-controller back * change names * updates * add field InitRequired * remove KsInitParams * migrate * Add status to notebook (kubeflow#2558) * wip * wip * update test to check status condition * fix * Add prodonjs to OWNERS (kubeflow#2613) * Changed sidebar tab from JupyterHub to Notebooks (kubeflow#2619) * fix (kubeflow#2620) * pf gcb (kubeflow#2603) * Setting the base_url flag of Jupyter images (kubeflow#2627) * set base_url of jupyter * change the env base_url to NB_PREFIX to sync with kubeflow#2620 * fix (kubeflow#2631) * resolve merge conflicts from upstream/master, fix error on master when --platform=none or not specified * store non exist parameter differently (kubeflow#2625) * fix (kubeflow#2632) * update pipeline system images to 0.1.12 release (kubeflow#2637) * updated jupyter image paths to point to the latest ones (kubeflow#2638) * add retry around ks init (kubeflow#2643) * add retry around ks init * update comments * merge errors * Getting started card completed (kubeflow#2651) * Getting Started card content added, and un-hidden. Windows support added in webpack to run dev builds * Getting Started card fully implemented from mocks * Spaced out cards a little more * Got eslint working! And fixed eslint issues in webpack
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
…low#2626) * Separate front-end components and add mock activities service. - Adds deep-link routing behavior for all front-end pages. Iframed pages reflect a URL to the browser that makes them linkable but hides the internal page. - Seperates the front-end into subcomponents, including an activities view. - Fix iframe view behavior to have it cover the space voided by the layout header. - Adds /api/activities endpoint to the Express server for activities to eventually be replaced with real data. - Sets the _devMode flag to true based on the webpack build env. * Address PR comments * Merge changes from PR kubeflow#2651
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 12, 2021
* Getting Started card content added, and un-hidden. Windows support added in webpack to run dev builds * Getting Started card fully implemented from mocks * Spaced out cards a little more * Got eslint working! And fixed eslint issues in webpack
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 12, 2021
…forms' (kubeflow#2547) * revert to prior version * fixes kfctl (golang) rename 'ks' directory and app to ksonnet and ksonnet.go respectively * fixes 'kfctl - Fetch registry automatically' * fixes 'refactor gcp, minikube, docker-for-desktop, ack to be kfctl plugins' * change DefaultDevRepo to point to just the repo not repo/kubeflow * fixes 'refactor gcp, minikube, docker-for-desktop, ack to be kfctl plugins' * plugins for all existing KfApp instances {ksonnet, minikube, foo}. * update golang version * fixes 'docker-for-desktop' * delete meta-controller-cluster-role-binding * update README.md * remove unused var DEBUG * remove bootstrap/cmd/plugins/foo.go * fixes kfctl (golang) rename 'ks' directory and app to ksonnet and ksonnet.go respectively * fixes 'add the gcp platform to kfctl (golang)' * fix merge conflict * cli option --project is an init flag * fix to write out project to app.yaml * fix for nil project check * include fix for kubeflow#2367 * added updateDM, createSecrets to Apply * fixes to macros * merge changes from upstream master * remove old files, update README.md * fix for init app-name where app-name is not a path * fix for gcp apply * code to create a Gcp Secret, doesn't do correct auth right now * snapshot * update on downloadK8sManifests, gcpInitProject, added TODO's * additional work on gcpInitProject * gcpInitProject now works but requires GOOGLE_APPLICATION_CREDENTIALS env var * initial pass on updateDeployment * update README.md to described static vs dynamic platforms * updates to Gcp.updateDM, added GOOGLE_APPLICATION_CREDENTIALS to the Makefile tests * minor changes on init, generate usage * snapshot * additional global resources identified * do not delete scalingpolicies * change default platform to ksonnet * default --version to master until 0.5.0 * remove verbose from spark-operator apply * address comments from Jeremy * address comments from Jeremy * fixes kubeflow#2537, refer to no platform as 'none' * add general test for kfctl in Makefile that also tests the plugin capability * remove kftcl config since we now have bootstrap config, fix for DefaultPlatform="none" * change test of platform none to create directory none, updated README * remove reference to docker-for-desktop * update README.md, remove --debug flag (not used) * fixes 'kfctl (golang) Simplify the child/parent relationships in platforms' * fix backendconfig name (kubeflow#2542) * fix backendconfig name * fix test * pin to the latest verified tf-operator commit in order to enable changes in tf-operator HEAD whcih likely break kubeflow checkout tests * fix (kubeflow#2506) * Added unit tests for GetUpdatedPolicy at gcpUtils.go - bootstrap/app (kubeflow#2516) * Added tests for 'GetUpdatedPolicy' - bootstrap/app * Fix typo - gcpUtils_test.go * Added a windows equivalent script for the makefile for central-dashboard (kubeflow#2518) * update katib component (kubeflow#2553) * Refactor for Express + Webpack build stack. (kubeflow#2572) * Refactor for Express + Webpack build stack. - Add webpack to process front-end code in public/ - Add TS and Express for server backend - Update Dockerfile to run the server as Node. - Fix issue with external links. * Updates based on feedback * address review comments * move tests under test directory * Add ESLint to enforce Google JS style in public/ (kubeflow#2579) * Add ESLint to enforce Google JS style in public/ * Switch to 4 space tabs * Updating python package imports related to tf-operator (kubeflow#2581) * updated tf-operator imports * fixed a typo * fixed a typo * Profiles e2e test (kubeflow#2404) * profiles e2e test * fix * review comment * fix * fix * fix * fix * add retry * fix * Update the jupyter-web-app Image (kubeflow#2589) Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com> * Golang profile controller (kubeflow#2533) * init * create api * wip * fix * fix * fix * fix test * address review * fix test * make it cluster scope * fix test * fix test * fix * turnoff jupyter images authentication (kubeflow#2591) * Updated Jupyter image paths for using in notebook controller (kubeflow#2552) * updated jupyter image paths for using in notebook conroller * removed 1.4.1 image from the list of options * updated jupyter image tags to point to the latest verified ones * updated jupyter images to allow any origin (kubeflow#2606) * Removing prune for Subresource field in CRD (kubeflow#2598) * Adding backOffLimit field to metric collector spec (kubeflow#2597) * remove global resources by label rather than listing all and looking for the label * mv client to coordinator * Fixed Dashboard v0.0.1 w/ Polymer3 + Webpack (kubeflow#2576) * Multiple issues tackled: - Fixed webpack for windows (components/ is not a valid path in windows) - Spacing and semicolons matched to old-codebase - Added cross-platform support to npm run targets - Added missing dep (babel/polyfill) - Dashboard build version is now corrected and hover will reveal kubeflow vs Dashboard versions - Pug fixed to match syntax for empty-value attributes - Updated webpack for readability * Added babel-polyfill to runtime deps rather than dev deps * [Windows-only] Color coded all make output, Tag check added, failures now have messages, also dirty git output now has a warning during build * Updated new dashboard reference :v20190227-v0.4.0-rc.1-176-g738de035 * Fixed Multiple changes: - Server port fixed to 8082 which is what is needed for GKE deployment - Refactored some code * Final working state for new image * TS Changes * Build updated to match latest :v20190301-v0.4.0-rc.1-183-g07eecd2f * Migrated dev dependency to correct location * Uncommented linter, fixed PR comments from @prodonjs * updated jupyter images based on postsubmit results of kubeflow@598dd06 (kubeflow#2611) * Adding additional printer columns to display status (kubeflow#2609) * Adding additional printer columns to display status * Fixing tests * Semi-working kfctl go binary (kubeflow#2587) * Add flag --skip-init-gcp-project * fix gcpInitProject * update error msg * add deployment creation logic * fix bugs on generateDMData * fix bugs * add default config to ipName and hostName * fix bugs on app.yaml * add Fingerprint to update deployment * make network and gcfs as DM optional * add todos * add iam policy handlers * finish patch iam policy * adding poll op to dm api calls * add gke api version * temp * change mysqlPd/nfsPd names * remove * temp * add config types * add basic auth flag * move config to gcp * link use basic auth flag to generate * use basic auth to determine config path * change to gabrielwen repo for now * change config on the fly * change repo path * create new Genereate method * add required packages * implement NewGenerate * clean up default config and add on-the-fly configs * move config handling to ksonnet.go * add ks param set * add application as component * fix typo * add simple TargetConfiguration factory * add fixed backof * temp * fix from merge * make namespace in gke * bind user as default-admin in gke * finish createSecrets * write oauth secret * uncomment ks apply * add ks show * add ks apply logic to k8sutils * uncomment deployment * build rest.Config from remote * impersonate as admin for rbac * use remote config as REST client config * update default.yaml path * complete apply logic * add retry * add ignore * merge * remove temp comment * use backoff in gcp * remove progress as it is not updating * use backoff * use backoff * use default zone * fix zone config * add doc * add doc * update Makefile * fix flag doc * fix * doc * doc * add doc * sort packages and component names * shell out to gcloud and kubectl for now * remove some configs * fix * remove GkeApiVersion * add todo * add notebook-controller back * change names * updates * add field InitRequired * remove KsInitParams * migrate * Add status to notebook (kubeflow#2558) * wip * wip * update test to check status condition * fix * Add prodonjs to OWNERS (kubeflow#2613) * Changed sidebar tab from JupyterHub to Notebooks (kubeflow#2619) * fix (kubeflow#2620) * pf gcb (kubeflow#2603) * Setting the base_url flag of Jupyter images (kubeflow#2627) * set base_url of jupyter * change the env base_url to NB_PREFIX to sync with kubeflow#2620 * fix (kubeflow#2631) * resolve merge conflicts from upstream/master, fix error on master when --platform=none or not specified * store non exist parameter differently (kubeflow#2625) * fix (kubeflow#2632) * update pipeline system images to 0.1.12 release (kubeflow#2637) * updated jupyter image paths to point to the latest ones (kubeflow#2638) * add retry around ks init (kubeflow#2643) * add retry around ks init * update comments * merge errors * Getting started card completed (kubeflow#2651) * Getting Started card content added, and un-hidden. Windows support added in webpack to run dev builds * Getting Started card fully implemented from mocks * Spaced out cards a little more * Got eslint working! And fixed eslint issues in webpack
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 12, 2021
…low#2626) * Separate front-end components and add mock activities service. - Adds deep-link routing behavior for all front-end pages. Iframed pages reflect a URL to the browser that makes them linkable but hides the internal page. - Seperates the front-end into subcomponents, including an activities view. - Fix iframe view behavior to have it cover the space voided by the layout header. - Adds /api/activities endpoint to the Express server for activities to eventually be replaced with real data. - Sets the _devMode flag to true based on the webpack build env. * Address PR comments * Merge changes from PR kubeflow#2651
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Getting started card completed
Fixes #2562
This change is