add option service_type to set TFServing service type #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @lluunn |
|
@fxue please sync |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jlewi
added a commit
to jlewi/kubeflow
that referenced
this pull request
Aug 24, 2019
…ts; we need to set userid-prefix and userid-header parameters for the applications jupyter-webapp, profiles, and centraldashboard. Otherwise we end up setting those to the empty string and it thinks we are an anonymous user. Related to: kubeflow#3986
k8s-ci-robot
pushed a commit
that referenced
this pull request
Aug 24, 2019
…the applications repo for GCP configs (#3994) * Pull in the latest fixes to the applications repo. * This should pull in the fix to #3986 * Now that we cherrypicked #302 onto the v0.6-branch of manifests; we need to set userid-prefix and userid-header parameters for the applications jupyter-webapp, profiles, and centraldashboard. Otherwise we end up setting those to the empty string and it thinks we are an anonymous user. Related to: #3986 * Userid prefix needs a trailing : * Bug fix.
yanniszark
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Feb 15, 2021
elenzio9
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Oct 31, 2022
Added karlschriek
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#295
tf-serving : added optional parameter "service_type" default to clusterIP.
this parameter is then passed to modelService().
This can be tested as follows:
should see your serving component is now of type LoadBalancer instead of ClusterIP
This change is