Skip to content

Commit

Permalink
Set userid prefix and header for IAP and pull in the latest fixes to …
Browse files Browse the repository at this point in the history
…the applications repo for GCP configs (#3994)

* Pull in the latest fixes to the applications repo.

* This should pull in the fix to #3986

* Now that we cherrypicked #302 onto the v0.6-branch of manifests; we need to
set userid-prefix and userid-header parameters for the applications
jupyter-webapp, profiles, and centraldashboard.

Otherwise we end up setting those to the empty string and it thinks we
are an anonymous user.

Related to: #3986

* Userid prefix needs a trailing :

* Bug fix.
  • Loading branch information
jlewi authored and k8s-ci-robot committed Aug 24, 2019
1 parent 945a58b commit b17e7aa
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 3 deletions.
2 changes: 1 addition & 1 deletion bootstrap/config/kfctl_gcp_basic_auth.0.6.2.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ spec:
root: kubeflow-0.6.2
uri: https://github.com/kubeflow/kubeflow/archive/0dbd2550372c003ba69069aeee283bd59fb1341f.tar.gz
- name: manifests
uri: https://github.com/kubeflow/manifests/archive/104c5b8c8e1df2bd09a827c4e25295ce945e3459.tar.gz
uri: https://github.com/kubeflow/manifests/archive/1099a06.tar.gz
skipInitProject: true
useBasicAuth: true
useIstio: true
Expand Down
18 changes: 16 additions & 2 deletions bootstrap/config/kfctl_gcp_iap.0.6.2.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,11 @@ spec:
overlays:
- istio
- application
parameters:
- name: userid-header
value: X-Goog-Authenticated-User-Email
- name: userid-prefix
value: "accounts.google.com:"
repoRef:
name: manifests
path: common/centraldashboard
Expand All @@ -79,6 +84,11 @@ spec:
overlays:
- istio
- application
parameters:
- name: userid-header
value: X-Goog-Authenticated-User-Email
- name: userid-prefix
value: "accounts.google.com:"
repoRef:
name: manifests
path: jupyter/jupyter-web-app
Expand Down Expand Up @@ -259,7 +269,11 @@ spec:
parameters:
- initRequired: true
name: admin
# value: SET_EMAIL
# value: SET_EMAIL
- name: userid-header
value: X-Goog-Authenticated-User-Email
- name: userid-prefix
value: "accounts.google.com:"
repoRef:
name: manifests
path: profiles
Expand Down Expand Up @@ -300,7 +314,7 @@ spec:
# Commit for v0.6.2-rc.1
uri: https://github.com/kubeflow/kubeflow/archive/0dbd2550372c003ba69069aeee283bd59fb1341f.tar.gz
- name: manifests
uri: https://github.com/kubeflow/manifests/archive/104c5b8c8e1df2bd09a827c4e25295ce945e3459.tar.gz
uri: https://github.com/kubeflow/manifests/archive/1099a06.tar.gz
skipInitProject: true
useBasicAuth: false
useIstio: true

0 comments on commit b17e7aa

Please sign in to comment.