New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix jupyterlab by upgrading Jupyterlab #328
Conversation
/uncc @ankushagarwal |
I built a new image: And verified that JupyterLab is working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good but I don't understand any of Argo stuff:)
nit @inc0 can you run the "/lgtm" command? That will add the appropriate label. I'll have instructions up hopefully today for the request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@lluunn You need a "/" |
error about index.html not found * Upgrade JupyterLab to 0.31 try to fix it. * Built a new image gcr.io/kubeflow-images-staging/tensorflow-notebook-cpu:v20180301-1958-pr328-0bc73dc-a43d and verified that the image is working.
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi, lluunn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cancel hold |
/hold cancel |
* Add Dan Sun to the ci member list * Remove inactive ones * alphabetize
Fix #262
This change is