Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jupyterlab by upgrading Jupyterlab #328

Merged
merged 1 commit into from Mar 3, 2018

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Mar 2, 2018

  • An attempt to fix jupyterlab not working by upgrading jupyterlab.

Fix #262


This change is Reviewable

@jlewi
Copy link
Contributor Author

jlewi commented Mar 2, 2018

/uncc @ankushagarwal
/uncc @wbuchwalter

@jlewi
Copy link
Contributor Author

jlewi commented Mar 2, 2018

I built a new image:
gcr.io/kubeflow-images-staging/tensorflow-notebook-cpu:v20180301-1958-pr328-0bc73dc-a43d

And verified that JupyterLab is working.

@jlewi
Copy link
Contributor Author

jlewi commented Mar 2, 2018

This is ready for review. But please only look at the second commit. The first commit will be submitted in #317

/cc @inc0
/cc @lluunn

Hold until #317 is merged
/hold

@k8s-ci-robot k8s-ci-robot requested review from inc0 and lluunn March 2, 2018 14:44
@jlewi jlewi changed the title [WIP] Fix jupyterlab by upgrading Jupyterlab Fix jupyterlab by upgrading Jupyterlab Mar 2, 2018
Copy link

@inc0 inc0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but I don't understand any of Argo stuff:)

@jlewi
Copy link
Contributor Author

jlewi commented Mar 2, 2018

nit @inc0 can you run the "/lgtm" command? That will add the appropriate label. I'll have instructions up hopefully today for the request.

lluunn
lluunn previously approved these changes Mar 2, 2018
Copy link
Contributor

@lluunn lluunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jlewi
Copy link
Contributor Author

jlewi commented Mar 2, 2018

@lluunn You need a "/"

  error about index.html not found

* Upgrade JupyterLab to 0.31 try to fix it.

* Built a new image
  gcr.io/kubeflow-images-staging/tensorflow-notebook-cpu:v20180301-1958-pr328-0bc73dc-a43d

 and verified that the image is working.
@lluunn
Copy link
Contributor

lluunn commented Mar 3, 2018

/lgtm

@jlewi
Copy link
Contributor Author

jlewi commented Mar 3, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi, lluunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlewi
Copy link
Contributor Author

jlewi commented Mar 3, 2018

/cancel hold

@jlewi
Copy link
Contributor Author

jlewi commented Mar 3, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 9118129 into kubeflow:master Mar 3, 2018
elenzio9 pushed a commit to arrikto/kubeflow that referenced this pull request Oct 31, 2022
* Add Dan Sun to the ci member list

* Remove inactive ones

* alphabetize
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JupyterLab not working in latest notebook images
4 participants