Remove -E from find command as it is not supported by GNU find #357
Conversation
BSD find BRE does not support alteration operator, so using two find commands instead of one.
scripts/autoformat_jsonnet.sh
Outdated
| @@ -18,10 +18,22 @@ | |||
| # Assumes jsonnet is on the path. | |||
| set -ex | |||
|
|
|||
| script_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" | |||
There was a problem hiding this comment.
What does script_dir end up being set to? Why isn't using pwd sufficient?
I think we want to use the current working directory because we want to be able to use this script to format jsonnet files in other repositories.
There was a problem hiding this comment.
script_dir is the directory in which autoformat_jsonnet.sh lives.
pwd also works fine - the reason I made this change was to support calling autoformat_jsonnet.sh from any directory. The result would be same whether the script was executed from the root directory of the repo or the scripts/ directory of the repo.
I can change it back to pwd if you prefer.
|
/lgtm Looks like it got of sync. Once you resolve conflicts you can just "/approve" it yourself. |
|
/hold |
|
/unapprove |
|
/approve cancel |
|
/retest |
|
/approve |
|
/hold cancel |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This reverts commit c614f25.
BSD find BRE does not support alteration operator, so using
two find commands instead of one.
Tested on OSX and Ubuntu
Fixes #345
This change is