Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -E from find command as it is not supported by GNU find #357

Merged
merged 5 commits into from
Mar 8, 2018
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
local params = std.extVar("__ksonnet/params").components.workflows;

local k = import 'k.libsonnet';
local workflows = import 'workflows.libsonnet';
local k = import "k.libsonnet";
local workflows = import "workflows.libsonnet";

std.prune(k.core.v1.list.new([workflows.parts(params.namespace, params.name, overrides=params).e2e]))
Original file line number Diff line number Diff line change
Expand Up @@ -22,22 +22,22 @@

// Default parameters.
defaultParams:: {
bucket: "mlkube-testing_temp",
commit: "master",
// Name of the secret containing GCP credentials.
gcpCredentialsSecretName: "kubeflow-testing-credentials",
name: "new9",
namespace: "kubeflow-test-infra",
// The name of the NFS volume claim to use for test files.
nfsVolumeClaim: "nfs-external",
prow_env: "REPO_OWNER=kubeflow,REPO_NAME=kubeflow,PULL_BASE_SHA=master",
serving_image: "gcr.io/mlkube-testing/model-server:1.0",
// The default image to use for the steps in the Argo workflow.
testing_image: "gcr.io/mlkube-testing/kubeflow-testing",
tf_testing_image: "gcr.io/kubeflow-ci/tf-test-worker:1.0",
project: "mlkube-testing",
cluster: "kubeflow-testing",
zone: "us-east1-d",
bucket: "mlkube-testing_temp",
commit: "master",
// Name of the secret containing GCP credentials.
gcpCredentialsSecretName: "kubeflow-testing-credentials",
name: "new9",
namespace: "kubeflow-test-infra",
// The name of the NFS volume claim to use for test files.
nfsVolumeClaim: "nfs-external",
prow_env: "REPO_OWNER=kubeflow,REPO_NAME=kubeflow,PULL_BASE_SHA=master",
serving_image: "gcr.io/mlkube-testing/model-server:1.0",
// The default image to use for the steps in the Argo workflow.
testing_image: "gcr.io/mlkube-testing/kubeflow-testing",
tf_testing_image: "gcr.io/kubeflow-ci/tf-test-worker:1.0",
project: "mlkube-testing",
cluster: "kubeflow-testing",
zone: "us-east1-d",
},

parts(namespace, name, overrides={}):: {
Expand Down Expand Up @@ -80,50 +80,50 @@
// Build an Argo template to execute a particular command.
// step_name: Name for the template
// command: List to pass as the container command.
local buildTemplate(step_name, command, env_vars=[], sidecars=[])= {
name: step_name,
container: {
command: command,
image: testing_image,
env: [
{
// Add the source directories to the python path.
name: "PYTHONPATH",
value: kubeflowPy + ":" + kubeflowTestingPy,
},
{
name: "GOOGLE_APPLICATION_CREDENTIALS",
value: "/secret/gcp-credentials/key.json",
},
{
name: "GITHUB_TOKEN",
valueFrom: {
secretKeyRef: {
name: "github-token",
key: "github_token",
},
local buildTemplate(step_name, command, env_vars=[], sidecars=[]) = {
name: step_name,
container: {
command: command,
image: testing_image,
env: [
{
// Add the source directories to the python path.
name: "PYTHONPATH",
value: kubeflowPy + ":" + kubeflowTestingPy,
},
{
name: "GOOGLE_APPLICATION_CREDENTIALS",
value: "/secret/gcp-credentials/key.json",
},
{
name: "GITHUB_TOKEN",
valueFrom: {
secretKeyRef: {
name: "github-token",
key: "github_token",
},
},
] + prow_env + env_vars,
volumeMounts: [
{
name: dataVolume,
mountPath: mountPath,
},
{
name: "github-token",
mountPath: "/secret/github-token",
},
{
name: "gcp-credentials",
mountPath: "/secret/gcp-credentials",
},
],
},
sidecars: sidecars,
}; // buildTemplate
},
] + prow_env + env_vars,
volumeMounts: [
{
name: dataVolume,
mountPath: mountPath,
},
{
name: "github-token",
mountPath: "/secret/github-token",
},
{
name: "gcp-credentials",
mountPath: "/secret/gcp-credentials",
},
],
},
sidecars: sidecars,
}; // buildTemplate

{
{
apiVersion: "argoproj.io/v1alpha1",
kind: "Workflow",
metadata: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ local hidden = {
},
},

mapContainersWithName(names, f) ::
mapContainersWithName(names, f)::
local nameSet =
if std.type(names) == "array"
then std.set(names)
Expand All @@ -32,46 +32,46 @@ local hidden = {
),
};

k8s + {
apps:: apps + {
v1beta1:: apps.v1beta1 + {
k8s {
apps:: apps {
v1beta1:: apps.v1beta1 {
local v1beta1 = apps.v1beta1,

daemonSet:: v1beta1.daemonSet + {
daemonSet:: v1beta1.daemonSet {
mapContainers(f):: hidden.mapContainers(f),
mapContainersWithName(names, f):: hidden.mapContainersWithName(names, f),
},

deployment:: v1beta1.deployment + {
deployment:: v1beta1.deployment {
mapContainers(f):: hidden.mapContainers(f),
mapContainersWithName(names, f):: hidden.mapContainersWithName(names, f),
},
},
},

core:: core + {
v1:: core.v1 + {
core:: core {
v1:: core.v1 {
list:: {
new(items)::
{apiVersion: "v1"} +
{kind: "List"} +
{ apiVersion: "v1" } +
{ kind: "List" } +
self.items(items),

items(items):: if std.type(items) == "array" then {items+: items} else {items+: [items]},
items(items):: if std.type(items) == "array" then { items+: items } else { items+: [items] },
},
},
},

extensions:: extensions + {
v1beta1:: extensions.v1beta1 + {
extensions:: extensions {
v1beta1:: extensions.v1beta1 {
local v1beta1 = extensions.v1beta1,

daemonSet:: v1beta1.daemonSet + {
daemonSet:: v1beta1.daemonSet {
mapContainers(f):: hidden.mapContainers(f),
mapContainersWithName(names, f):: hidden.mapContainersWithName(names, f),
},

deployment:: v1beta1.deployment + {
deployment:: v1beta1.deployment {
mapContainers(f):: hidden.mapContainers(f),
mapContainersWithName(names, f):: hidden.mapContainersWithName(names, f),
},
Expand Down