Fix tfjob dashboard ambassador route #381
Conversation
| "prefix: /tfjobs/ui/", | ||
| "rewrite: /", | ||
| "prefix: /tfjobs/", | ||
| "rewrite: /tfjobs/", |
There was a problem hiding this comment.
Can you add a comment explaining why prefix and rewrite are set the way they are? I would like to understand better what it takes to make Ambassador work. Does the TFJobs UI expect that is rooted at "/"?
There was a problem hiding this comment.
Please see explanation here: kubeflow/training-operator#441 (comment)
There was a problem hiding this comment.
@jlewi Did you have a chance to look at my explanations?
|
@wbuchwalter Sorry this slipped my mind again. Make sure you /assign me so it shows up in my PR dashboard |
|
/assign |
|
/lgtm |
|
/retest |
|
presubmit didn't seem to run. |
|
/retest |
|
/assign jlewi |
|
/test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* v1alpha2 API proposal * Fix comments round 1 * Refactor into Experiment and Trial * Incorporate feedback from meeting * Rename * Minor edits
Needed for: kubeflow/training-operator#441
This change is