Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kfctl: pin configs to v0.6.1 #3864

Closed

Conversation

yanniszark
Copy link
Contributor

@yanniszark yanniszark commented Aug 10, 2019

Fixes #3862

This PR pins the kubeflow and manifests repo versions to v0.6.1 (which is the latest release) for all configs.

/assign @abhi-g @lluunn

Signed-off-by: Yannis Zarkadas yanniszark@arrikto.com


This change is Reviewable

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign yanniszark
You can assign the PR to them by writing /assign @yanniszark in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lluunn
Copy link
Contributor

lluunn commented Aug 10, 2019

I think we want to pin only at 0.6, so PR should make to v0.6-branch?

@yanniszark
Copy link
Contributor Author

@lluunn why is that? The latest release is v0.6.1. Why not use that?

cc @abhi-g

@lluunn
Copy link
Contributor

lluunn commented Aug 10, 2019

Why not master points to master, 0.6 points to 0.6?

Also test is using the config file, and master should be tested.

@abhi-g
Copy link
Member

abhi-g commented Aug 10, 2019 via email

@jlewi
Copy link
Contributor

jlewi commented Aug 11, 2019

It looks like this PR would be pinning the version on master.
Should we instead check this change in to the v0.6-branch of kubeflow/kubeflow?

I think it makes sense for kubeflow/kubeflow master to point to master of kubeflow/manifests

@yanniszark
Copy link
Contributor Author

@jlewi sounds good to me.
I'll submit a pr for the v0.6-branch.

@yanniszark
Copy link
Contributor Author

I'm closing this one for #3867

@yanniszark yanniszark closed this Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.6 kfctl_k8s_istio.yaml config should point to 0.6 manifests repos
6 participants