-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kfctl: pin configs to v0.6.1 #3864
kfctl: pin configs to v0.6.1 #3864
Conversation
Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think we want to pin only at 0.6, so PR should make to v0.6-branch? |
Why not master points to master, 0.6 points to 0.6? Also test is using the config file, and master should be tested. |
I think Lun-kai's point is to pin to the v0.6-branch rather than a tag such
as v0.6.0, v0.6.1 etc. That way if we have patch releases, we won't need to
update these.
Abhishek
…On Sat, Aug 10, 2019 at 10:47 AM Yannis Zarkadas ***@***.***> wrote:
@lluunn <https://github.com/lluunn> why is that? The latest release is
v0.6.1. Why not use that?
cc @abhi-g <https://github.com/abhi-g>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3864?email_source=notifications&email_token=ACZ2UZTIHSSKRDCYCNMDZKLQD35LHA5CNFSM4IKZLBNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4ASB7Y#issuecomment-520167679>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACZ2UZVGYR4X6TQAF2WZS43QD35LHANCNFSM4IKZLBNA>
.
|
It looks like this PR would be pinning the version on master. I think it makes sense for kubeflow/kubeflow master to point to master of kubeflow/manifests |
@jlewi sounds good to me. |
I'm closing this one for #3867 |
Fixes #3862
This PR pins the kubeflow and manifests repo versions to v0.6.1 (which is the latest release) for all configs.
/assign @abhi-g @lluunn
Signed-off-by: Yannis Zarkadas yanniszark@arrikto.com
This change is