kfctl: pin configs to v0.6-branch #3867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
This was referenced Aug 12, 2019
lluunn
reviewed
Aug 12, 2019
bootstrap/config/kfctl_aws.yaml
Outdated
| - name: manifests | ||
| root: manifests-master | ||
| uri: https://github.com/kubeflow/manifests/archive/master.tar.gz | ||
| root: manifests-v0.6-branch |
There was a problem hiding this comment.
I downloaded the file from the uri, the dir name is manifests-0.6-branch.
(No v)
There was a problem hiding this comment.
Thanks for catching this.
Seems really weird that github would change the pattern for this branch.
I thought the naming was supposed to always be: <repo>-<branch>
Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
|
/lgtm cc @kunmingg |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lluunn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @abhi-g @jlewi @lluunn
Signed-off-by: Yannis Zarkadas yanniszark@arrikto.com
This change is