Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #3941: Fix the error link description when using kfctl install. Cherry pick of #3941 on v0.6-branch. #3941: Fix the error link description when using kfctl install. #3942

Conversation

xauthulei
Copy link
Member

@xauthulei xauthulei commented Aug 19, 2019

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @xauthulei. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jinchihe
Copy link
Member

/ok-to-test

/cc @jlewi

@xauthulei Could you please apply to Kubeflow memeber following the guide so that your PR will test automatically.
Thanks for your great contribution!

@xauthulei
Copy link
Member Author

@jinchihe , Thanks again for your great efforts here. I have created a PR135 to apply for being a member of this great open project.

@jlewi
Copy link
Contributor

jlewi commented Aug 19, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 00096f0 into kubeflow:v0.6-branch Aug 19, 2019
@xauthulei xauthulei deleted the automated-cherry-pick-of-#3941-upstream-v0.6-branch branch August 20, 2019 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants