Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws] Clean up alb and istio dependencies in kfctl delete #4383

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Oct 23, 2019

Resolve #4382 and part of #3767

Make sure user delete won't have left over and cluster can be teared down.


This change is Reviewable

@Jeffwan
Copy link
Member Author

Jeffwan commented Oct 23, 2019

/cc @jlewi

@richardsliu
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0ba828a into kubeflow:master Oct 24, 2019
@Jeffwan Jeffwan deleted the aws-0.7 branch October 24, 2019 05:22
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kfctl delete leave over application load balancer (aws)
4 participants