Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubeflow AWS 0.7 issues #4354

Closed
Jeffwan opened this issue Oct 20, 2019 · 10 comments
Closed

Kubeflow AWS 0.7 issues #4354

Jeffwan opened this issue Oct 20, 2019 · 10 comments

Comments

@Jeffwan
Copy link
Member

Jeffwan commented Oct 20, 2019

/kind bug

We have few issues open and need to be resolved for 0.7. Create this issue to track AWS specific bugs and issues.

Environment:

  • Kubeflow version: (version number can be found at the bottom left corner of the Kubeflow dashboard):
  • kfctl version: (use kfctl version): 0.7
  • Kubernetes platform: (e.g. minikube)
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@issue-label-bot
Copy link

Issue Label Bot is not confident enough to auto-label this issue.
See dashboard for more details.

@Jeffwan
Copy link
Member Author

Jeffwan commented Oct 20, 2019

@jlewi jlewi added this to To Do in 0.7.0 via automation Oct 21, 2019
@jlewi
Copy link
Contributor

jlewi commented Oct 21, 2019

@Jeffwan I just approved kubeflow/manifests#518 but I think you will need to cherry pick it onto the v0.7-branch of kubeflow/manifests

@jlewi jlewi moved this from To Do to Needs Fix in 0.7.0 Oct 21, 2019
@jlewi
Copy link
Contributor

jlewi commented Oct 24, 2019

@Jeffwan Any update on this? It looks like kubeflow/manifests#518 just merged to master so I'm guessing we need to cherry pick it onto the 0.7 branch.

@Jeffwan
Copy link
Member Author

Jeffwan commented Oct 24, 2019

Hi @jlewi one last change here. kubeflow/manifests#567
I will submit a PR to cherry-pick #518 and kubeflow/manifests#567 together to 0.7-branch on Thursday morning. No other aws code changes for 0.7.

In addition, we need to figure out the right flow here. #4368
It's a blocking change now..

@jlewi
Copy link
Contributor

jlewi commented Oct 24, 2019

@Jeffwan See my response on #4368

@Jeffwan
Copy link
Member Author

Jeffwan commented Oct 24, 2019

@jlewi Yeah, I will have doc change later on. Next step is to have some logic in build to make sure user can use Env and Template to build kustomize in one command. I will do this for next release.

The last two cherry-pick PRs for aws. Then we are good to go.

kubeflow/manifests#572
#4392

@Jeffwan
Copy link
Member Author

Jeffwan commented Oct 24, 2019

/assign @Jeffwan

@Jeffwan
Copy link
Member Author

Jeffwan commented Oct 24, 2019

No pending PRs. Thanks for the help.

/close

List recent changes relate to this story for tracking.
#4356 Fix aws plugin not found issue
#4383 Clean up alb and istio dependencies in kfctl delete
#4390 Fix apply overrides custom changes after Build for aws config

kubeflow/manifests#518 Add application name for seldon and mpi-operator
kubeflow/manifests#567 Clean up istio gateway and virtual services.

kubeflow/website#1244 Updated the AWS guides for kfctl v0.7
kubeflow/website#1271 Pin aws manifests to 0.7.0 and Update aws docs

@k8s-ci-robot
Copy link
Contributor

@Jeffwan: Closing this issue.

In response to this:

No pending PRs. Thanks for the help.

/close

List recent changes relate to this story for tracking.
#4356 Fix aws plugin not found issue
#4383 Clean up alb and istio dependencies in kfctl delete
#4390 Fix apply overrides custom changes after Build for aws config

kubeflow/manifests#518 Add application name for seldon and mpi-operator
kubeflow/manifests#567 Clean up istio gateway and virtual services.

kubeflow/website#1244 Updated the AWS guides for kfctl v0.7
kubeflow/website#1271 Pin aws manifests to 0.7.0 and Update aws docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

0.7.0 automation moved this from Needs Fix to Done Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
0.7.0
  
Done
Development

No branches or pull requests

3 participants