Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameter to mount path for notebook PVC #469

Closed
wants to merge 2 commits into from
Closed

Add parameter to mount path for notebook PVC #469

wants to merge 2 commits into from

Conversation

inc0
Copy link

@inc0 inc0 commented Mar 20, 2018 •
edited by jlewi

This change allows command ks param set kubeflow-core
jupyterNotebookPVCMount << mount path >>. If you specify empty string
("") there it will remove PVC creation at all, which is useful in envs
without proper StorageClass.

Fixes #365

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jlewi

Assign the PR to them by writing /assign @jlewi in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@inc0
Copy link
Author

inc0 commented Mar 20, 2018

/assign @jlewi

@inc0
Copy link
Author

inc0 commented Mar 20, 2018

/retest

@jlewi
Copy link
Contributor

jlewi commented Mar 21, 2018

Looks good except for the failing test.

@inc0 inc0 force-pushed the issue/365 branch 2 times, most recently from 2c6cc53 to 61cff97 Compare March 21, 2018 22:51
@inc0
Copy link
Author

inc0 commented Mar 22, 2018

/retest

@jlewi
Copy link
Contributor

jlewi commented Mar 23, 2018

I think test flakes might have been fixed please try syncing.

@inc0
Add parameter to mount path for notebook PVC
5934258 
This change allows command ks param set kubeflow-core
jupyterNotebookPVCMount << mount path >>. If you specify empty string
("") there it will remove PVC creation at all, which is useful in envs
without proper StorageClass.

Fixes kubeflow#365
@inc0 inc0 force-pushed the issue/365 branch 2 times, most recently from 360c3f7 to cf2c6c1 Compare March 23, 2018 20:49
@k8s-ci-robot
Copy link
Contributor

@inc0: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubeflow-presubmit 67cb893 link /test kubeflow-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jlewi
Copy link
Contributor

jlewi commented Mar 26, 2018

Looks like its the jsonnet_test that's still failing.
#508 includes some updates to the test that should make it easier to keep the test up to date and might help in this PR.

@jlewi
Copy link
Contributor

jlewi commented Mar 27, 2018

Are we going to submit this PR or #503

Can you try rebasing and squashing the commits to see if that fixes the CLA check?

/assign @kkasravi

@jlewi jlewi mentioned this pull request Mar 27, 2018
Merged
@inc0
Copy link
Author

inc0 commented Mar 27, 2018

I'll close this one and let's work on #503

@inc0 inc0 closed this Mar 27, 2018
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
@andreyvelich @k8s-ci-robot
Add serviceAccountName in UI deployment (kubeflow#469)
bc57a6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimexist jimexist Awaiting requested review from jimexist

@zjj2wry zjj2wry Awaiting requested review from zjj2wry

Assignees

@kkasravi kkasravi

@jlewi jlewi

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@inc0 @k8s-ci-robot @jlewi @kkasravi