Update release instructions to ease onboarding #493
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it! (I hadn't added my "official" corporate email to my GitHub account.) |
|
CLAs look good, thanks! |
This commit: 1. Adds instructions for authenticating to GCP, 2. adds instructions for setting the right kubectl context, and 3. ensures that workflow names are less than 63 characters.
willb
force-pushed
the
initial-release-process
branch
from
a39be23
to
de8d2be
Compare
|
@jlewi PTAL; I think we can remove the WIP from this. |
willb
changed the title
|
(After this is merged, we can cut a |
|
/assign jlewi |
| If you're new to using GKE or are new to the release team, you'll need to authenticate to GCP first. [Install the `gcloud` tool](https://cloud.google.com/sdk/gcloud/) and then execute the following commands, substituting your release team account for `your-team-account@kubeflow.org`: | ||
|
|
||
| ``` | ||
| gcloud config set account your-team-account@kubeflow.org |
There was a problem hiding this comment.
gcloud config set account
Most people won't have kubeflow.org accounts and this makes it seem like they need one.
They don't.
They just need to be added to
release-team@kubeflow.org
| cd ${GIT_KUBEFLOW} | ||
| git checkout ${COMMIT} | ||
| cd components/tensorflow-notebook-image/releaser | ||
| ``` | ||
|
|
||
| ``` | ||
| PULL_BASE_SHA=<commit to build> | ||
| PULL_BASE_SHA=${COMMIT:0:8} | ||
| DATE=`date +%Y%m%d` | ||
| VERSION_TAG="v${DATE}-${PULL_BASE_SHA}" | ||
| JOB_NAME="tensorflow-notebook-image-release" |
There was a problem hiding this comment.
Can you add instructions for cutting a branch?
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* update profile config to v1beta1 resolve comments; update CRD; remove common prefix and namespace tests auto update fix service account name move default profile CR into new pkg: default-install resolve comments more update * rebase and update tests * fix format error
* Work in progress on updating release instructions. This commit: 1. Adds instructions for authenticating to GCP, 2. adds instructions for setting the right kubectl context, and 3. ensures that workflow names are less than 63 characters. * This commit improves instructions and fixes a spurious environment variable
This commit:
Related to
#215 Minimal release process
#506 Cut a 0.1 release
This change is