Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install jupyter widgets in tensorflow-notebook-image #518

Merged
merged 1 commit into from Mar 28, 2018

Conversation

pdmack
Copy link
Member

@pdmack pdmack commented Mar 27, 2018

Fixes #489

@jlewi Your instructions appear to be correct for py3. Not sure why it was failing in your env. I tested with interact but maybe you have something else in mind.

screen shot 2018-03-27 at 5 03 38 pm


This change is Reviewable

Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlewi
Copy link
Contributor

jlewi commented Mar 28, 2018

/approve

@jlewi
Copy link
Contributor

jlewi commented Mar 28, 2018

@willingc FYI we use prow to manage PRs so if you want to actually lgtm PRs you need to do "/lgtm"

@jlewi
Copy link
Contributor

jlewi commented Mar 28, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 392741a into kubeflow:master Mar 28, 2018
@pdmack pdmack deleted the widget-install branch April 2, 2018 13:39
@Jeffwan Jeffwan mentioned this pull request Oct 24, 2019
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Nov 1, 2019
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
Signed-off-by: Ce Gao <gaoce@caicloud.io>
elenzio9 pushed a commit to arrikto/kubeflow that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants