Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial ksonnet package for Pachyderm. #610

Merged
merged 5 commits into from Apr 9, 2018

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Apr 6, 2018


This change is Reviewable

* Packages were created based on the helm chart
https://github.com/kubernetes/charts/tree/master/stable/pachyderm/templates

* Instructions for adding new packages is being added in kubeflow#609.

* I've confirmed that the resulting components can successfully be deployed
  but I don't know if Pachyderm is working yet.

* We most likely need to expose more options e.g. to control things
  like GCS bucket.

* Related to kubeflow#151
@jlewi
Copy link
Contributor Author

jlewi commented Apr 6, 2018

/assign @dwhitena

@k8s-ci-robot
Copy link
Contributor

@jlewi: GitHub didn't allow me to assign the following users: dwhitena.

Note that only kubeflow members and repo collaborators can be assigned.

In response to this:

/assign @dwhitena

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlewi jlewi changed the title Initial ksonnet package for Pachyderm. [WIP] Initial ksonnet package for Pachyderm. Apr 7, 2018
@jlewi jlewi changed the title [WIP] Initial ksonnet package for Pachyderm. Initial ksonnet package for Pachyderm. Apr 7, 2018
@pdmack
Copy link
Member

pdmack commented Apr 8, 2018

/lgtm

# oc get svc | grep pach
pachd              NodePort    10.103.96.5      <none>        650:30650/TCP,651:30651/TCP,652:30652/TCP   16m
# export ADDRESS=127.0.0.1:30650
# pachctl list-repo
NAME                CREATED             SIZE

I don't know that much about pachyderm but seems like it deployed OK.

BTW, this seems hella confusing with ksonnet:

 #  ks registry add kubeflow github.com/jlewi/kubeflow/tree/pachyderm/kubeflow --version=pachyderm
 #  ks pkg install kubeflow/pachyderm@pachyderm

Why am I over-specifying the GH ref for that branch?

@pdmack
Copy link
Member

pdmack commented Apr 9, 2018

/lgtm cancel
I think the dashboard should come out if its behind their paywall.

@jlewi
Copy link
Contributor Author

jlewi commented Apr 9, 2018

Agreed.

@pdmack
Copy link
Member

pdmack commented Apr 9, 2018

/retest

@pdmack
Copy link
Member

pdmack commented Apr 9, 2018

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pdmack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6f83562 into kubeflow:master Apr 9, 2018
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
* Initial ksonnet package for Pachyderm.

* Packages were created based on the helm chart
https://github.com/kubernetes/charts/tree/master/stable/pachyderm/templates

* Instructions for adding new packages is being added in kubeflow#609.

* I've confirmed that the resulting components can successfully be deployed
  but I don't know if Pachyderm is working yet.

* We most likely need to expose more options e.g. to control things
  like GCS bucket.

* Related to #151

* Added dash.

* Fix the dashboard; need to set DASH_SERVICE_HOST.

* Remove the dashboard because its behind a paywall.
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants