Change naming from jupyter to jupyterhub when referring to hub #642
Conversation
|
/assign @jlewi |
|
Do you also want to rename https://github.com/kubeflow/kubeflow/blob/master/kubeflow/core/jupyterhub_spawner.py? Since we aren't actually spawning JupyterHub? |
|
@jlewi Hmm... I didn't think of that one before. It may be best as kubeform_spawner. I guess it depends if you think there may be swapping of spawners over time. You make the call :-) |
|
kubeform_spawner seems good to me. |
|
/test all |
|
/ok-to-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…low#642) * Change naming from jupyter to jupyterhub when referencing the hub * Change jupyter to jupyterhub when referring to the hub * Change references to jupyter to jupyterhub when hub is being used * Rename jupyterhub spawner to kubeform_spawner * update docs for name changes
This PR should add more consistent naming (and less confusion down the road) by using jupyterhub when referencing the JupyterHub hub. Typically, the Jupyter team refers to the Jupyter notebook or the team itself when using Jupyter name. JupyterHub is used to reference all hub related components and activities.
@jlewi I think I caught all the non-doc places that this occurred.
This change is