Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change naming from jupyter to jupyterhub when referring to hub #642

Merged
merged 5 commits into from
Apr 12, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion components/jupyterhub/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ Jupyter notebooks. JupyterHub delegates the launching of
single-user notebooks to pluggable components called “spawners”. JupyterHub
has a sub-project named kubespawner, maintained by the
community, that enables users to provision single-user Jupyter notebooks backed by Kubernetes pods - the notebooks themselves are
Kubernetes pods.
Kubernetes pods. kubeform_spawner extends kubespawner to enable users to have
a form to specify cpu, memory, gpu, and desired image.

## Quick Start

Expand Down
2 changes: 1 addition & 1 deletion docs_dev/releasing.md
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ ks param set --env=${ENV} workflows prow_env \
ks apply ${ENV} -c workflows
```

Create a PR to update [jupyterhub_spawner.py](https://github.com/kubeflow/kubeflow/blob/master/kubeflow/core/jupyterhub_spawner.py#L15)
Create a PR to update [kubeform_spawner.py](https://github.com/kubeflow/kubeflow/blob/master/kubeflow/core/kubeform_spawner.py#L15)
to point to the newly built Jupyter notebook images.

## Create a release branch (if necessary)
Expand Down
4 changes: 2 additions & 2 deletions kubeflow/core/all.libsonnet
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{
parts(params):: {
local ambassador = import "kubeflow/core/ambassador.libsonnet",
local jupyter = import "kubeflow/core/jupyterhub.libsonnet",
local jupyterhub = import "kubeflow/core/jupyterhub.libsonnet",
local nfs = import "kubeflow/core/nfs.libsonnet",
local tfjob = import "kubeflow/core/tf-job.libsonnet",
local spartakus = import "kubeflow/core/spartakus.libsonnet",
local centraldashboard = import "kubeflow/core/centraldashboard.libsonnet",

all:: jupyter.all(params)
all:: jupyterhub.all(params)
+ tfjob.all(params)
+ ambassador.all(params)
+ nfs.all(params)
Expand Down
2 changes: 1 addition & 1 deletion kubeflow/core/jupyterhub.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

kubeSpawner(authenticator, volumeClaims=[]): {
// TODO(jlewi): We should make whether we use PVC configurable.
local baseKubeConfigSpawner = importstr "jupyterhub_spawner.py",
local baseKubeConfigSpawner = importstr "kubeform_spawner.py",

authenticatorOptions:: {

Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion kubeflow/core/tests/jupyterhub_test.jsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ local params = {
jupyterNotebookPVCMount: "/home/jovyan/work",
};

local baseSpawner = importstr "../jupyterhub_spawner.py";
local baseSpawner = importstr "../kubeform_spawner.py";

// TODO(jlewi): We should be able to use std.startsWidth in later versions of jsonnet.
//
Expand Down
4 changes: 2 additions & 2 deletions testing/test_deploy.py
Original file line number Diff line number Diff line change
Expand Up @@ -238,9 +238,9 @@ def deploy_kubeflow(args):
util.wait_for_deployment(api_client, namespace, tf_job_deployment_name)

# Verify that JupyterHub is actually deployed.
jupyter_name = "tf-hub"
jupyterhub_name = "tf-hub"
logging.info("Verifying TfHub started.")
util.wait_for_statefulset(api_client, namespace, jupyter_name)
util.wait_for_statefulset(api_client, namespace, jupyterhub_name)


def deploy_model(args):
Expand Down
22 changes: 11 additions & 11 deletions testing/workflows/vendor/kubeflow/core/prototypes/all.jsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
// because ksonnet doesn't support inheriting it from the environment yet.

local k = import "k.libsonnet";
local jupyter = import "kubeflow/core/jupyterhub.libsonnet";
local jupyterhub = import "kubeflow/core/jupyterhub.libsonnet";
local tfjob = import "kubeflow/core/tf-job.libsonnet";
local nfs = import "kubeflow/core/nfs.libsonnet";

Expand All @@ -32,9 +32,9 @@ local diskNames = if diskParam != "null" && std.length(diskParam) > 0 then
std.split(diskParam, ",")
else [];

local jupyterConfigMap = if std.length(diskNames) == 0 then
jupyter.parts(namespace).jupyterHubConfigMap
else jupyter.parts(namespace).jupyterHubConfigMapWithVolumes(diskNames);
local jupyterHubConfigMap = if std.length(diskNames) == 0 then
jupyterhub.parts(namespace).jupyterHubConfigMap
else jupyterhub.parts(namespace).jupyterHubConfigMapWithVolumes(diskNames);

local tfJobImage = import "param://tfJobImage";
local tfDefaultImage = import "param://tfDefaultImage";
Expand Down Expand Up @@ -64,13 +64,13 @@ local nfsComponents =

std.prune(k.core.v1.list.new([
// jupyterHub components
jupyterConfigMap,
jupyter.parts(namespace).jupyterHubService,
jupyter.parts(namespace).jupyterHubLoadBalancer(jupyterHubServiceType),
jupyter.parts(namespace).jupyterHub(jupyterHubImage),
jupyter.parts(namespace).jupyterHubRole,
jupyter.parts(namespace).jupyterHubServiceAccount,
jupyter.parts(namespace).jupyterHubRoleBinding,
jupyterHubConfigMap,
jupyterhub.parts(namespace).jupyterHubService,
jupyterhub.parts(namespace).jupyterHubLoadBalancer(jupyterHubServiceType),
jupyterhub.parts(namespace).jupyterHub(jupyterHubImage),
jupyterhub.parts(namespace).jupyterHubRole,
jupyterhub.parts(namespace).jupyterHubServiceAccount,
jupyterhub.parts(namespace).jupyterHubRoleBinding,

// TfJob controller
tfjob.parts(namespace).tfJobDeploy(tfJobImage),
Expand Down