Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose NotebookCullingCount and NotebookCullingTimestamp in prometheus metrics #6488

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

henrysecond1
Copy link
Contributor

Currently, notebook culling metrics are not exported.

This PR fixes two things

  • Export culling metrics
  • Remove duplicated increment of notebook_culling_total (incremented twice in SetStopAnnotation and Reconcile)

@aws-kf-ci-bot
Copy link

Hi @henrysecond1. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign yanniszark after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanniszark in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@henrysecond1 henrysecond1 changed the title Export notebook culling metrics notebooks: Export notebook culling metrics May 25, 2022
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@juliusvonkohout
Copy link
Member

is this something you want @kubeflow/wg-notebooks-leads ?

@juliusvonkohout
Copy link
Member

Can you join the next notebooks WG meeting in two weeks ? We are always looking for help.

https://www.kubeflow.org/docs/about/community/#kubeflow-community-calendars has the calendar and meeting notes.

You can also reach us on slack in the channel wg-notebooks and wg-manifests.

@thesuperzapper thesuperzapper added this to the v1.9.1 milestone May 12, 2024
@thesuperzapper thesuperzapper changed the title notebooks: Export notebook culling metrics feat: expose NotebookCullingCount and NotebookCullingTimestamp in prometheus metrics May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants