Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tensorboard-controller: Fix tensorboard endless restarts #6722

Merged
merged 1 commit into from Nov 9, 2022

Conversation

oshep
Copy link
Contributor

@oshep oshep commented Nov 8, 2022

tensorboard-controller: Fix tensorboard endless restarts
tensorboards-web-app deletes objects using foreground deletion policy, Tensorboard CR will stay until all owned objects are deleted reconcile loop might keep on trying to recreate the resources that the API server tries to delete. so when Tensorboard CR is terminating, reconcile loop should do nothing

This commit allow manager to skip reconcile while Tensorboard CR is deleting.

@oshep
Copy link
Contributor Author

oshep commented Nov 8, 2022

Hi there!
I'm faced with the issue that Tensorboards web app stucks on deletion process.
I've investigate the problem and found that child resources are deleted and automatically generated by the controller in a loop. It leads to stucking of deletion process.
The solution is pretty similar like it done for the notebook-controller manager.
fc09bd1

@kimwnasptd
Copy link
Member

Nice catch, thanks @oshep!

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CybervisionVolodymyrPogorelov, kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit c790417 into kubeflow:master Nov 9, 2022
maroroman pushed a commit to maroroman/kubeflow that referenced this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants