Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tensorboard-controller: Fix tensorboard endless restarts #6722

Merged
merged 1 commit into from
Nov 9, 2022
Merged

tensorboard-controller: Fix tensorboard endless restarts #6722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions components/tensorboard-controller/controllers/tensorboard_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,14 @@ func (r *TensorboardReconciler) Reconcile(ctx context.Context, req ctrl.Request)
return reconcile.Result{}, err
}

// tensorboards-web-app deletes objects using foreground deletion policy, Tensorboard CR will stay until all owned objects are deleted
// reconcile loop might keep on trying to recreate the resources that the API server tries to delete.
// so when Tensorboard CR is terminating, reconcile loop should do nothing

if !instance.DeletionTimestamp.IsZero() {
return ctrl.Result{}, nil
}

// Reconcile k8s deployment.
deployment, err := generateDeployment(instance, logger, r)
if err != nil {
Expand Down