Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @angular/material in WAs #6763

Merged

Conversation

elenzio9
Copy link
Contributor

In this PR, we upgrade the @angular/material package in WAs to fix the x button misalignment reported here: #6754 (comment)

image

Related issue: #6462

Related PR: #6754

* Upgrade @angular/material package to align the mat-chip x button.

Signed-off-by: Elena Zioga <elena@arrikto.com>
* Upgrade @angular/material package to align the mat-chip x button.

Signed-off-by: Elena Zioga <elena@arrikto.com>
* Upgrade @angular/material package to align the mat-chip x button.

Signed-off-by: Elena Zioga <elena@arrikto.com>
@kimwnasptd
Copy link
Member

Thanks!

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit be90c7c into kubeflow:master Nov 23, 2022
@kimwnasptd kimwnasptd deleted the feature-elena-wa-update-material branch November 23, 2022 15:07
maroroman pushed a commit to maroroman/kubeflow that referenced this pull request Feb 7, 2023
* jwa(front): Upgrade @angular/material package (kubeflow#6462)

* Upgrade @angular/material package to align the mat-chip x button.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* vwa(front): Upgrade @angular/material package (kubeflow#6462)

* Upgrade @angular/material package to align the mat-chip x button.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Upgrade @angular/material package (kubeflow#6462)

* Upgrade @angular/material package to align the mat-chip x button.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants