Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for linux/ppc64le in CI for centraldashboard multi-arc… #6923

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Adding support for linux/ppc64le in CI for centraldashboard multi-arc… #6923

merged 1 commit into from
Feb 6, 2023

Conversation

amitmukati-2604
Copy link
Contributor

…h docker images

@amitmukati-2604
Copy link
Contributor Author

  • The workflow "centraldb_docker_publish" releases docker image for Linux-amd64.
  • Added docker-build-multi-arch and build-push-multi-arch targets in the Makefile of the Tensorboard-controller component.
  • Dropping docker-build and docker-push from the workflow.
  • Keeping these steps will increase the workflow runtime.
  • Docker-build-push-multi-arch builds and pushes the images for Linux-amd64 and Linux-ppc64le

@kimwnasptd
Copy link
Member

@apo-ger could you also take a stab at it? Should be the same with the rest of the updates we did for ppc64le

/cc @apo-ger

@apo-ger
Copy link
Contributor

apo-ger commented Feb 1, 2023

Changes look good!
/lgtm

@apo-ger
Copy link
Contributor

apo-ger commented Feb 1, 2023

/remove-lgtm

Actually I'm getting an error while trying to build the image.

EDIT: Apologies for the confusion, everything work as expected!

@google-oss-prow google-oss-prow bot removed the lgtm label Feb 1, 2023
@apo-ger
Copy link
Contributor

apo-ger commented Feb 1, 2023

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Feb 1, 2023
@lehrig
Copy link
Contributor

lehrig commented Feb 1, 2023

/assign @StefanoFioravanzo

...just needs an approval now.

@kimwnasptd
Copy link
Member

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants