Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

centraldashboard(make): Use correct dir #6960

Conversation

kimwnasptd
Copy link
Member

Previously the app would not use the correct directory when running the docker buildx command, which resulted in the image to fail to get built.

I also realized that we are not testing the docker buildx flow in each PR, this is why this was never caught in #6923. We'll need to extend the current actions to use the same build process to ensure we catch this in a timely manner.

I'll ping on the corresponding issue
/cc @elikatsis

Previously the app would not use the correct directory when running the
docker buildx command, which resulted in the image to fail to get built.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
@elikatsis
Copy link
Member

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elikatsis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 1036595 into kubeflow:master Feb 15, 2023
@kimwnasptd kimwnasptd deleted the feature-kimwnasptd-centraldashboard-buildx-dir branch February 15, 2023 13:36
@kimwnasptd
Copy link
Member Author

Looks like even after merging this PR the image can't be built. The reason in this case though has to do with ppc64le. I'm seeing these logs when building for the ppc64le:
https://github.com/kubeflow/kubeflow/actions/runs/4184427448/jobs/7250059227

#23 [linux/ppc64le build 5/5] RUN BUILDARCH="$(dpkg --print-architecture)" &&  npm rebuild &&     if [ "$BUILDARCH" = "arm64" ]  ||      [ "$BUILDARCH" = "armhf" ]; then     export CFLAGS=-Wno-error &&     export CXXFLAGS=-Wno-error;      fi &&     npm install &&     npm test &&     npm run build &&     npm prune --production
...
#23 320.5 15 02 2023 13:47:25.388:ERROR [launcher]: Cannot start ChromeHeadless
#23 320.5 	find: '/root/.config/chromium/Crash Reports/pending/': No such file or directory
#23 320.5 [0215/134718.429805:ERROR:bus.cc(399)] Failed to connect to the bus: Failed to connect to socket /run/dbus/system_bus_socket: No such file or directory
#23 320.5 [0215/134718.618224:ERROR:bus.cc(399)] Failed to connect to the bus: Failed to connect to socket /run/dbus/system_bus_socket: No such file or directory
#23 320.5 [0215/134718.618972:ERROR:bus.cc(399)] Failed to connect to the bus: Failed to connect to socket /run/dbus/system_bus_socket: No such file or directory

The above doesn't get triggered for the linux/amd64 arch.

My best guess is that this happens because there's an issue with running the Chromium process inside of the ppc64le container. The reason chromium needs to run in the first place is because in the CentralDashboard we run some frontend tests as part of the docker build process.

IIRC this decision was from the very early days of Kubeflow, where we had very limited CI capabilities. I'd propose to actually create a separate workflow for running the frontend tests and removing this logic altogether cc @tasos-ale @orfeas-k. I'll take a look ASAP at this, since we need to release a CentralDashboard image for the next RC cc @DomFleischmann

I'll also do a cc @lehrig for visibility, since this got triggered for ppc64le

kimwnasptd added a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2023
Previously the app would not use the correct directory when running the
docker buildx command, which resulted in the image to fail to get built.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
google-oss-prow bot pushed a commit that referenced this pull request Feb 15, 2023
Previously the app would not use the correct directory when running the
docker buildx command, which resulted in the image to fail to get built.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants