-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(notebooks): propagate annotations from notebook cr to pods #7076
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@kimwnasptd @StefanoFioravanzo Can I get approval this? Please let me know if you have any questions |
Thanks for the contribution @moorthy156! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…flow/kubeflow#7076) Co-authored-by: osd530 <narayanamurthi.mari@capitalone.com>
…flow/kubeflow#7076) Co-authored-by: osd530 <narayanamurthi.mari@capitalone.com>
…flow/kubeflow#7076) Co-authored-by: osd530 <narayanamurthi.mari@capitalone.com>
…flow/kubeflow#7076) Co-authored-by: osd530 <narayanamurthi.mari@capitalone.com>
…flow/kubeflow#7076) Co-authored-by: osd530 <narayanamurthi.mari@capitalone.com>
Added Annotation propagation logic to notebook controllers. This will help to propagate custom annotations like kiam to notebook pods from notebook custom resource.
This pr fixes issue #6677
Results:
Annotation on Notebook CR:
Annotation on Notebook Pod: