Update PVCViewer manifests

[TobiasGoerke]

• roleRef.name now matches role.metadata.name.
  Without this change, kustomize build doesn't correctly bind the resulting clusterrolebinding.
• Remove creationTimestamp: null as noted by @axel7083
• Use commonLabels over labels to comply with old kustomize version. Also, I had to introduce the deprecated vars feature as replacements aren't supported with the current kustomize version used by the build pipeline

See #6876 for initial PR.

[TobiasGoerke]

/approve

[axel7083]

While this PR is open and focused on fixing changed in yaml files, maybe take a look at the following:

kubeflow/components/pvcviewer-controller/config/crd/bases/kubeflow.org_pvcviewers.yaml

Lines 6 to 8 in 3733989

	controller-gen.kubebuilder.io/version: v0.10.0
	creationTimestamp: null
	name: pvcviewers.kubeflow.org

kubeflow/components/pvcviewer-controller/config/rbac/role.yaml

Lines 4 to 6 in 3733989

	metadata:
	creationTimestamp: null
	name: role

Why creationTimestamp is null ? It prevents the resource to be deployed on my side.

PS: I can open an issue, if you do not want to fix in this PR
@TobiasGoerke

[TobiasGoerke]

While this PR is open and focused on fixing changed in yaml files, maybe take a look at the following:

kubeflow/components/pvcviewer-controller/config/crd/bases/kubeflow.org_pvcviewers.yaml

Lines 6 to 8 in 3733989

	controller-gen.kubebuilder.io/version: v0.10.0
	creationTimestamp: null
	name: pvcviewers.kubeflow.org

kubeflow/components/pvcviewer-controller/config/rbac/role.yaml

Lines 4 to 6 in 3733989

	metadata:
	creationTimestamp: null
	name: role

Why creationTimestamp is null ? It prevents the resource to be deployed on my side.

PS: I can open an issue, if you do not want to fix in this PR @TobiasGoerke

Good catch. Fixed, thanks!
kubebuilder adds these fields automatically, which is a well-known issue.

[TobiasGoerke]

/assign kimwnasptd

[TobiasGoerke]

/lgtm
/approve

[google-oss-prow]

@TobiasGoerke: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TobiasGoerke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• components/pvcviewer-controller/OWNERS [TobiasGoerke]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kimwnasptd]

@TobiasGoerke could you rebase on top of latest master now that #7219 is merged?

[TobiasGoerke]

@TobiasGoerke could you rebase on top of latest master now that #7219 is merged?

Done. Looking good now, both unit and integration tests run successfully

[kimwnasptd]

Nice!

/lgtm

[TobiasGoerke]

@kimwnasptd the docker build pipeline failed: https://github.com/kubeflow/kubeflow/actions/runs/5718096836. Same goes for the notebook controller which I copied the pipeline off with the same error: https://github.com/kubeflow/kubeflow/actions/runs/5717331751. Looks like there might be a superfluous comma in the platform arg?