Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PVCViewer Frontend Integration #7179

Merged

Conversation

TobiasGoerke
Copy link
Contributor

As discuseed in #6876, I've integrated the PVCViewer into the volumes UI.

You may test this by deploying the PVCViewer (make sure to merge/apply #7178 first) and the changed volumes UI.

@TobiasGoerke
Copy link
Contributor Author

/assign kimwnasptd

@kimwnasptd
Copy link
Member

@TobiasGoerke could you do one more rebase here as well to make sure all tests are running as expected?

@TobiasGoerke
Copy link
Contributor Author

@TobiasGoerke could you do one more rebase here as well to make sure all tests are running as expected?

Done. Looking good.
Btw, can you manually trigger the backend docker pipeline, now that it is fixed?

@kimwnasptd
Copy link
Member

Looks good! Nice to see a dedicated button as well for stopping the viewer

/lgtm
/approe

@google-oss-prow google-oss-prow bot added the lgtm label Aug 4, 2023
@kimwnasptd
Copy link
Member

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit f4f8bf1 into kubeflow:master Aug 4, 2023
8 checks passed
@TobiasGoerke TobiasGoerke deleted the volumes-viewer-frontend branch October 19, 2023 05:30
@thesuperzapper thesuperzapper modified the milestone: v1.9.0 May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants