-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kubeflow 1.8] release: bump container images to tag 1.8.0-rc.0 and bump release version #7234
[kubeflow 1.8] release: bump container images to tag 1.8.0-rc.0 and bump release version #7234
Conversation
@DnPlas From the file changes and GitHub actions logs, it's hard to tell why it's failing. Can you help debug this further to gather better logs for the problem? possibly using https://github.com/marketplace/actions/debugging-with-ssh or outputting data as artifact? |
@DnPlas thanks for the PR! Looking into those to unblock us. Most probably it's a race on how we check for some manifests to be there. I'll keep you posted |
I'm pretty sure we have the same race in the tests in manifests, where we check for the Trial CR before it's created kubeflow/manifests#2508 (comment). The test code is applying the manifests and then directly waiting for Pods, which might not have yet been created
The solution here should be in each test to either:
I'll send a follow-up PR to fix this. Ideally I'd like to avoid adding |
I submitted a set of commits correcting the VERSION and image tags ( Kindly review the changes, if everything looks good, let's merge. |
One of the failing latest CI run shows the following error:
I increased the timeout, but I'm not sure this is helping. |
Reopening PR as it was mistakenly closed by #7263 |
This commit updates the release tag for container images and adds pvc-viewer to update-manifests-images script
afe2c8a
to
41e8119
Compare
Thanks for coordinating and pushing this @DnPlas! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Following the releasing steps, update the manifests to use the v1.8.0-rc.1 tag and bump version in
version/VERSION
.cc: @annajung @kimwnasptd