-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix test image replacement #7263
ci: fix test image replacement #7263
Conversation
/cc @kimwnasptd @DnPlas |
Thanks @thesuperzapper, lgtm, but I'd kindly ask @kimwnasptd to review and approve. |
Thanks @thesuperzapper! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@DnPlas can you cherry-pick in release branch and I can help merge? |
* ci: use proper env ref, and set job concurrency * ci: fix test image replacement --------- Co-authored-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
* ci: use proper env ref, and set job concurrency * ci: fix test image replacement --------- Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> Co-authored-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
Supersedes #7252
Fixes #7234
This PR does the following:
${{env.TAG}}
, with their safer equivalents in bash, e.g.${TAG}
latest
: