Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.8.0-rc.2 #7347

Merged

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Oct 16, 2023

Bump release version v1.8.0-rc.1 -> v1.8.0-rc.2

cc: @kimwnasptd

@kimwnasptd
Copy link
Member

kimwnasptd commented Oct 16, 2023

Looks like the Notebook Controller is failing for the same reason like

@DnPlas could you send a small PR to only update the golang version used to run the unit tests to 1.20?
https://github.com/kubeflow/kubeflow/blob/master/.github/workflows/notebook_controller_unit_test.yaml#L17

@DnPlas
Copy link
Contributor Author

DnPlas commented Oct 16, 2023

@kimwnasptd sent a patch in #7348 , thanks!

@DnPlas DnPlas force-pushed the dnplas-bump-version-1.8.0-rc.2 branch from d6ba1f9 to 178e993 Compare October 16, 2023 08:18
@kimwnasptd
Copy link
Member

Thank you @DnPlas for the help!

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit d91e1f2 into kubeflow:v1.8-branch Oct 16, 2023
25 checks passed
@kimwnasptd
Copy link
Member

Looks like only the workflow for the CentralDashboard in Angular failed
https://github.com/kubeflow/kubeflow/actions/runs/6531881039/job/17733960649

I think we should drop this automation, until the effort will get back some traction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants