poddefaults: Bump golang to 1.20 #7338
Conversation
Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
|
@kimwnasptd: GitHub didn't allow me to assign the following users: tzstoyanov. Note that only kubeflow members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kimwnasptd
deleted the
feature-kimwnasptd-poddefaults-tests-golang-ver
branch
Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
* Bump the controller-runtime version to 0.16.2 (#7322) * Bump the controller-runtime version to 0.16.2 There are a lot of improvements, optimizations and bug fixes in the latest version, related to the controller-runtime client which is used in admission-webhook. Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com> * Set logger for controller-runtime The latest version of controller-runtime client requires to set in advance a logger, used by the client. Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com> * Use golang version 1.21 for container build The latest version of controller-runtime package requires golang v.1.21 for building. Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com> --------- Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com> * poddefaults: Bump golang to 1.20 (#7338) Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> --------- Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com> Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> Co-authored-by: Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
During #7322 the tests were not triggered so we missed the failing unit-tests action. We found this out during cherry-picking #7337
This is because it needed golang at least 1.20 during the unit tests, to install one of the dependencies.
I also went and updated the golang version of the component and am testing to make sure we didn't miss something
/assign @tzstoyanov @thesuperzapper