Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: downgrade jupyterlab to 3.6.6 #7398

Merged

Conversation

thesuperzapper
Copy link
Member

@thesuperzapper thesuperzapper commented Oct 31, 2023

Follow up to #7357

This PR downgrades JupyterLab to 3.6.6 and Jupyter Notebooks to 6.5.6.

This is to ensure compatibility with JupyterLab extensions which have not supported JupyterLab 4.0 yet.

I have also re-added the jupyterlab-git extension, as this was one of the plugins that did not support 4.0.

Finally, I have updated the kfp version to 2.4.0, as this version fixes a bug uncovered in Kubeflow 1.8.0-rc.4.

@thesuperzapper
Copy link
Member Author

/assign @DnPlas

@thesuperzapper
Copy link
Member Author

@DnPlas I am going to self-approve here, so you can LGTM to merge it, then wait for the builds before cherry-picking into the release-1.8 branch.

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thesuperzapper , should we only change the jupyterlab related packages? I think we should not touch other packages, specially kfp.

@thesuperzapper
Copy link
Member Author

thesuperzapper commented Oct 31, 2023

@DnPlas the KFP packages were part of the fix found in testing for Kubeflow 1.8.0-rc.4, so it would be a bit crazy to ship a known broken version of the kfp package?

Here is the changelog for the KFP package: https://github.com/kubeflow/pipelines/blob/master/sdk/RELEASE.md

Also, the other changes are to ensure that conda/pip does not randomly update to the latest JupyterLab (which I was experiencing in testing).

@DnPlas
Copy link
Contributor

DnPlas commented Oct 31, 2023

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Oct 31, 2023
@google-oss-prow google-oss-prow bot merged commit 1b2448c into kubeflow:master Oct 31, 2023
2 checks passed
@thesuperzapper thesuperzapper deleted the downgrade-jupyterlab branch October 31, 2023 21:06
DnPlas pushed a commit to DnPlas/kubeflow that referenced this pull request Oct 31, 2023
DnPlas added a commit that referenced this pull request Oct 31, 2023
Cherry pick 1b2448c into v1.8-branch

Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 22, 2024
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 22, 2024
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 22, 2024
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 23, 2024
Adembc pushed a commit to Adembc/notebooks that referenced this pull request Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants