-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: downgrade jupyterlab to 3.6.6 #7398
fix: downgrade jupyterlab to 3.6.6 #7398
Conversation
/assign @DnPlas |
@DnPlas I am going to self-approve here, so you can LGTM to merge it, then wait for the builds before cherry-picking into the /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @thesuperzapper , should we only change the jupyterlab related packages? I think we should not touch other packages, specially kfp.
@DnPlas the KFP packages were part of the fix found in testing for Kubeflow 1.8.0-rc.4, so it would be a bit crazy to ship a known broken version of the kfp package? Here is the changelog for the KFP package: https://github.com/kubeflow/pipelines/blob/master/sdk/RELEASE.md Also, the other changes are to ensure that conda/pip does not randomly update to the latest JupyterLab (which I was experiencing in testing). |
/lgtm |
Follow up to #7357
This PR downgrades JupyterLab to 3.6.6 and Jupyter Notebooks to 6.5.6.
This is to ensure compatibility with JupyterLab extensions which have not supported JupyterLab 4.0 yet.
I have also re-added the
jupyterlab-git
extension, as this was one of the plugins that did not support 4.0.Finally, I have updated the
kfp
version to2.4.0
, as this version fixes a bug uncovered in Kubeflow 1.8.0-rc.4.